Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1450722
| From | Jeff Kirsher <jeffrey.t.kirsher@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2 |
| Date | 2016-07-26 20:00 +0200 |
| Message-ID | <rZeO5-55G-5@gated-at.bofh.it> (permalink) |
| References | <rYSky-7wc-27@gated-at.bofh.it> <rZeuJ-4Z7-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Tue, 2016-07-26 at 13:39 -0400, Jarod Wilson wrote: > Per Jesse Brandeburg, e1000e should be using flags for this sort of > thing. > > Littering functional code with device-specific checks is much messier > than > simply checking a flag, and having device-specific init set flags as > needed. > There are probably a number of other cases in the e1000e code that > could/should be converted similarly. > > At present, this patch is a follow-up to the previously submitted 2 > patches, but I can redo the series to omit the conversion to a switch > entirely, if so desired. > > Suggested-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > CC: Jesse Brandeburg <jesse.brandeburg@intel.com> > CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > CC: intel-wired-lan@lists.osuosl.org > CC: netdev@vger.kernel.org > Signed-off-by: Jarod Wilson <jarod@redhat.com> > --- > drivers/net/ethernet/intel/e1000e/82571.c | 6 ++++-- > drivers/net/ethernet/intel/e1000e/e1000.h | 1 + > drivers/net/ethernet/intel/e1000e/ich8lan.c | 3 ++- > drivers/net/ethernet/intel/e1000e/netdev.c | 10 ++-------- > 4 files changed, 9 insertions(+), 11 deletions(-) This generates a compile issue, so I will be dropping this patch and will await an update.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2 Jarod Wilson <jarod@redhat.com> - 2016-07-26 19:40 +0200
Re: [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2 Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2016-07-26 20:00 +0200
Re: [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2 Jarod Wilson <jarod@redhat.com> - 2016-07-26 20:00 +0200
csiph-web