Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1450698
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] cfag12864b: Remove deprecated create_singlethread_workqueue |
| Date | 2016-07-26 19:10 +0200 |
| Message-ID | <rZe1I-4Pb-29@gated-at.bofh.it> (permalink) |
| References | <rZdS2-4t5-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Jul 26, 2016 at 10:23:00PM +0530, Bhaktipriya Shridhar wrote:
> @@ -257,7 +256,6 @@ void cfag12864b_disable(void)
> if (cfag12864b_updating) {
> cfag12864b_updating = 0;
> cancel_delayed_work(&cfag12864b_work);
> - flush_workqueue(cfag12864b_workqueue);
It should be converted to cancel_delayed_work_sync(); otherwise,
nothing guarantees that the work item is finished.
Thanks.
--
tejun
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] cfag12864b: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-07-26 19:00 +0200 Re: [PATCH] cfag12864b: Remove deprecated create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-07-26 19:10 +0200
csiph-web