Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1450635

[PATCH v3 0/6] Finally fix watermarks

Show all headers | View raw

So unfortunately, this patch series fixes most of the underruns on Skylake, but
not all of them. Even with this patchset we're still apt to potentially hitting
underruns since we don't update the ddb allocations atomically as well yet. I'm
planning to do this eventually when I get the chance, but for now this patch
series will improve the underrun situation on Skylake dramatically.

Since the last patch series, I've brought back the patch
"Always wait for pipes to update after a flush". While this patch doesn't
entirely fix things either, it lessens the chance of hitting underruns when
enabling/disabling pipes. Since we only flush when the ddb allocations change
now, another vblank wait in there shouldn't be a huge deal.

As well I've included the SAGV patch this time, since it's required for this
patch series to work properly anyhow and it's been updated. Figured it'd be
better to put everything in one place.

Lyude (5):
  drm/i915/skl: Add support for the SAGV, fix underrun hangs
  drm/i915/skl: Only flush pipes when we change the ddb allocation
  drm/i915/skl: Fix extra whitespace in skl_flush_wm_values()
  drm/i915/skl: Update plane watermarks atomically during plane updates
  drm/i915/skl: Always wait for pipes to update after a flush

Matt Roper (1):
  drm/i915/gen9: Only copy WM results for changed pipes to skl_hw

 drivers/gpu/drm/i915/i915_drv.h      |   3 +
 drivers/gpu/drm/i915/i915_reg.h      |   5 +
 drivers/gpu/drm/i915/intel_display.c |   5 +
 drivers/gpu/drm/i915/intel_drv.h     |   2 +
 drivers/gpu/drm/i915/intel_pm.c      | 245 +++++++++++++++++++++++++++++++----
 drivers/gpu/drm/i915/intel_sprite.c  |   2 +
 6 files changed, 239 insertions(+), 23 deletions(-)

-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/6] Finally fix watermarks Lyude <cpaul@redhat.com> - 2016-07-26 17:00 +0200
  [PATCH v3 3/6] drm/i915/skl: Only flush pipes when we change the ddb allocation Lyude <cpaul@redhat.com> - 2016-07-26 17:00 +0200
  [PATCH v3 6/6] drm/i915/skl: Always wait for pipes to update after a flush Lyude <cpaul@redhat.com> - 2016-07-26 17:00 +0200
  Re: [PATCH v3 1/6] drm/i915/skl: Add support for the SAGV, fix  underrun hangs Maarten Lankhorst <maarten.lankhorst@linux.intel.com> - 2016-07-26 17:00 +0200
    Re: [PATCH v3 1/6] drm/i915/skl: Add support for the SAGV, fix  underrun hangs Ville Syrjälä <ville.syrjala@linux.intel.com> - 2016-07-26 17:20 +0200
  [PATCH v3 5/6] drm/i915/skl: Update plane watermarks atomically during plane updates Lyude <cpaul@redhat.com> - 2016-07-26 17:00 +0200
  [PATCH v3 1/6] drm/i915/skl: Add support for the SAGV, fix underrun hangs Lyude <cpaul@redhat.com> - 2016-07-26 17:00 +0200

csiph-web