Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1452078

Re: [PATCH v4 2/2] spi: add driver for J-Core SPI controller

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Jul 28, 2016 at 03:40:45PM -0400, Rich Felker wrote:
> On Thu, Jul 28, 2016 at 08:11:53PM +0100, Mark Brown wrote:

> > An architecture or SoC dependency with || COMPILE_TEST would be useful
> > for avoiding cluttering Kconfig for other users.  Though as this is in a
> > FPGA it's perhaps likely people will pick this up for other FPGAs so
> > perhaps a comment to that effect if it seems likely.

> Unlike some of the other SoC hardware (interrupt controller) that's
> more closely tied to the SH cpu trap behavior, the SPI master seems
> like something that would be nice and easy to reuse elsewhere. I don't
> feel strongly about it either way though; I can add the arch dep if
> you want.

I guess it depends if anyone is actually doing that or not, if nobody is
the dependency would be better.

> > Why are you not using the clock API for this?  Just require a clock and
> > use clk_get_rate() to find out what rate it is.

> I thought about that but I'm not familiar with it. I can try to figure
> it out quickly and test that approach; don't see any reason it
> shouldn't work. Would you insist on having full support for
> enabling/disabling the clk when it's in use, or would you be happy
> with treating it as a fixed clock that's always-on for now and
> possibly extending it with more functionality later if there's ever
> hardware where that's relevant/helpful?

It's fine to just enable it at startup and leave it on, though the
runtime PM ops are trivial and you can set auto_runtime_pm to have the
core do the gets and puts.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/2] J-Core SPI controller support Rich Felker <dalias@libc.org> - 2016-07-28 08:20 +0200
  [PATCH v4 1/2] of: add J-Core SPI master bindings Rich Felker <dalias@libc.org> - 2016-07-28 08:20 +0200
    Re: [PATCH v4 1/2] of: add J-Core SPI master bindings Rob Herring <robh@kernel.org> - 2016-07-29 23:00 +0200
      Re: [PATCH v4 1/2] of: add J-Core SPI master bindings Rich Felker <dalias@libc.org> - 2016-08-03 00:10 +0200
        Re: [PATCH v4 1/2] of: add J-Core SPI master bindings Rob Herring <robh@kernel.org> - 2016-08-03 00:50 +0200
  [PATCH v4 2/2] spi: add driver for J-Core SPI controller Rich Felker <dalias@libc.org> - 2016-07-28 08:20 +0200
    Re: [PATCH v4 2/2] spi: add driver for J-Core SPI controller Mark Brown <broonie@kernel.org> - 2016-07-28 21:20 +0200
      Re: [PATCH v4 2/2] spi: add driver for J-Core SPI controller Rich Felker <dalias@libc.org> - 2016-07-28 21:50 +0200
        Re: [PATCH v4 2/2] spi: add driver for J-Core SPI controller Mark Brown <broonie@kernel.org> - 2016-07-28 22:00 +0200
          Re: [PATCH v4 2/2] spi: add driver for J-Core SPI controller Rich Felker <dalias@libc.org> - 2016-07-30 05:40 +0200
            Re: [PATCH v4 2/2] spi: add driver for J-Core SPI controller Mark Brown <broonie@kernel.org> - 2016-08-01 20:20 +0200
              Re: [PATCH v4 2/2] spi: add driver for J-Core SPI controller Rich Felker <dalias@libc.org> - 2016-08-02 03:50 +0200
                Re: [PATCH v4 2/2] spi: add driver for J-Core SPI controller Rob Landley <rob@landley.net> - 2016-08-02 20:20 +0200
            Re: [PATCH v4 2/2] spi: add driver for J-Core SPI controller Geert Uytterhoeven <geert@linux-m68k.org> - 2016-08-04 15:10 +0200
              Re: [PATCH v4 2/2] spi: add driver for J-Core SPI controller Rich Felker <dalias@libc.org> - 2016-08-04 19:10 +0200

csiph-web