Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1452063
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Input - elantech: fix debug dump of the current packet |
| Date | 2016-07-28 21:10 +0200 |
| Message-ID | <rZYQW-20O-25@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <rZYnU-1zx-11@gated-at.bofh.it> <rZYxz-1DB-1@gated-at.bofh.it> <rZYHg-1HJ-13@gated-at.bofh.it> <rZYHg-1HJ-11@gated-at.bofh.it> <rZYHg-1HJ-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On July 28, 2016 11:58:29 AM PDT, Joe Perches <joe@perches.com> wrote: >On Thu, 2016-07-28 at 11:54 -0700, Dmitry Torokhov wrote: >> On Thu, Jul 28, 2016 at 11:49:57AM -0700, Joe Perches wrote: >[] >> > So use dev_printk(KERN_DEBUG, etc... >> #define psmouse_printk(level, psmouse, format, ...) \ >> dev_printk(level, \ >> &(psmouse)->ps2dev.serio->dev, \ >> psmouse_fmt(format), ##__VA_ARGS__) >> >> I want to see current protocol module in th eoutput and I do not want >to >> write "&(psmouse)->ps2dev.serio->dev" all the time. > >There are only 2 uses of the macro. > >$ git grep psmouse_printk >drivers/input/mouse/elantech.c: psmouse_printk(KERN_DEBUG, >psmouse, \ >drivers/input/mouse/elantech.c: psmouse_printk(KERN_DEBUG, psmouse, >"PS/2 packet ["); >drivers/input/mouse/psmouse.h:#define psmouse_printk(level, psmouse, >format, ...) \ Yes, but many more of psmouse_<severity> calls and I like consistency. Thanks. -- Dmitry
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] Input - elantech: fix debug dump of the current packet Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-28 12:00 +0200
Re: [PATCH] Input - elantech: fix debug dump of the current packet Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-07-28 20:30 +0200
Re: [PATCH] Input - elantech: fix debug dump of the current packet Joe Perches <joe@perches.com> - 2016-07-28 20:40 +0200
Re: [PATCH] Input - elantech: fix debug dump of the current packet Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-07-28 20:50 +0200
Re: [PATCH] Input - elantech: fix debug dump of the current packet Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-07-28 21:00 +0200
Re: [PATCH] Input - elantech: fix debug dump of the current packet Joe Perches <joe@perches.com> - 2016-07-28 21:00 +0200
Re: [PATCH] Input - elantech: fix debug dump of the current packet Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-07-28 21:10 +0200
Re: [PATCH] Input - elantech: fix debug dump of the current packet Joe Perches <joe@perches.com> - 2016-07-28 21:00 +0200
csiph-web