Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1451900

Re: debug tip after earlycon is closed?

From Russell King - ARM Linux <linux@armlinux.org.uk>
Newsgroups linux.kernel
Subject Re: debug tip after earlycon is closed?
Date 2016-07-28 14:30 +0200
Message-ID <rZSBQ-6cq-13@gated-at.bofh.it> (permalink)
References <rZlPA-1a1-1@gated-at.bofh.it> <rZrBE-4PS-43@gated-at.bofh.it> <rZIVP-7X5-9@gated-at.bofh.it> <rZOeR-36k-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Jul 28, 2016 at 09:44:53AM +0200, Arnd Bergmann wrote:
> I think the problem is that you have three consoles:
> 
> - the boot console that stays active until a real console comes up
> - the framebuffer console that is initialized early and goes on to
>   disable the bootconsole
> - the serial console that you are looking at but which doesn't get
>   initialized until much later
> 
> Clearly something is wrong in this setup and we don't want to
> disable the boot console before the serial console is up.
> 
> I guess you could work around it by disabling the framebuffer console
> at compile time, or by having the serial console initialized earlier
> than the framebuffer, but I wonder if this is something that could
> use a more general solution.

I think this is down to how the linux,stdout property is handled.

Normally, with command line specified consoles, if you don't specify
anything, you get the framebuffer console (actually, it's the first
registered console, but practically this is the framebuffer if enabled)
by default.

If you specify a console (or consoles) on the command line, you get
all of those you specified, (iirc) with /dev/console's input connected
to the first specified console.

This happens because the command line is parsed for consoles, and
add_preferred_console() is called for each that are found, whether or
not drivers are discovered for them.  __add_preferred_console()
prevents the first registered console being automatically initialised
by setting selected_console to a non-negative number.

However, the parsing of DT specified consoles occurs at driver
initialisation time - in uart_add_one_port() via of_console_check().
Only at this time is add_preferred_console() called, which means that
the first console registered prior to _any_ selected UART console
driver mentioned in DT will become active.

When the first console becomes active, the earlycon is disabled, which
means that in the DT case, if we have a framebuffer enabled which
registers prior to any selected UART console, the framebuffer will
stop the earlycon output immediately.

To me, what this means is that the DT parsing of linux,stdout is
broken - while it may look nice from a design point of view, the
design is wrong and fails to take account of non-UART consoles in
the system.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

debug tip after earlycon is closed? Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-07-27 03:30 +0200
  Re: debug tip after earlycon is closed? Sebastian Reichel <sre@kernel.org> - 2016-07-27 04:20 +0200
    Re: debug tip after earlycon is closed? Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-07-27 05:30 +0200
  Re: debug tip after earlycon is closed? Arnd Bergmann <arnd@arndb.de> - 2016-07-27 09:40 +0200
    Re: debug tip after earlycon is closed? Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-07-28 04:10 +0200
      Re: debug tip after earlycon is closed? Arnd Bergmann <arnd@arndb.de> - 2016-07-28 09:50 +0200
        Re: debug tip after earlycon is closed? Russell King - ARM Linux <linux@armlinux.org.uk> - 2016-07-28 14:30 +0200
          Re: debug tip after earlycon is closed? Rabin Vincent <rabin@rab.in> - 2016-08-08 11:10 +0200

csiph-web