Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1451811
| Path | csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Bob Liu <bob.liu@oracle.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity |
| Date | Thu, 28 Jul 2016 11:10:01 +0200 |
| Message-ID | <rZPuh-48F-11@gated-at.bofh.it> (permalink) |
| References | <rZ36h-6p2-1@gated-at.bofh.it> <rZIj7-7ua-3@gated-at.bofh.it> |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=ISO-8859-1 |
| Content-Transfer-Encoding | 8bit |
| X-Source-IP | userv0021.oracle.com [156.151.31.71] |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 43 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, roger.pau@citrix.com |
| X-Original-Date | Thu, 28 Jul 2016 17:03:49 +0800 |
| X-Original-Message-ID | <5799CA75.6000701@oracle.com> |
| X-Original-References | <1469510377-15131-1-git-send-email-bob.liu@oracle.com> <20160728011942.GB3165@char.us.oracle.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1451811 |
Show key headers only | View raw
On 07/28/2016 09:19 AM, Konrad Rzeszutek Wilk wrote:
> On Tue, Jul 26, 2016 at 01:19:35PM +0800, Bob Liu wrote:
>> Two places didn't get updated when 64KB page granularity was introduced, this
>> patch fix them.
>>
>> Signed-off-by: Bob Liu <bob.liu@oracle.com>
>> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>
> Could you rebase this on xen-tip/for-linus-4.8 pls?
Done, sent the v2 for you to pick up.
>
>> ---
>> drivers/block/xen-blkfront.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
>> index fcc5b4e..032fc94 100644
>> --- a/drivers/block/xen-blkfront.c
>> +++ b/drivers/block/xen-blkfront.c
>> @@ -1321,7 +1321,7 @@ free_shadow:
>> rinfo->ring_ref[i] = GRANT_INVALID_REF;
>> }
>> }
>> - free_pages((unsigned long)rinfo->ring.sring, get_order(info->nr_ring_pages * PAGE_SIZE));
>> + free_pages((unsigned long)rinfo->ring.sring, get_order(info->nr_ring_pages * XEN_PAGE_SIZE));
>> rinfo->ring.sring = NULL;
>>
>> if (rinfo->irq)
>> @@ -2013,7 +2013,7 @@ static int blkif_recover(struct blkfront_info *info)
>>
>> blkfront_gather_backend_features(info);
>> segs = info->max_indirect_segments ? : BLKIF_MAX_SEGMENTS_PER_REQUEST;
>> - blk_queue_max_segments(info->rq, segs);
>> + blk_queue_max_segments(info->rq, segs / GRANTS_PER_PSEG);
>>
>> for (r_index = 0; r_index < info->nr_rings; r_index++) {
>> struct blkfront_ring_info *rinfo = &info->rinfo[r_index];
>> --
>> 1.7.10.4
>>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity Bob Liu <bob.liu@oracle.com> - 2016-07-26 07:30 +0200
[PATCH v2 2/3] xen-blkfront: introduce blkif_set_queue_limits() Bob Liu <bob.liu@oracle.com> - 2016-07-26 07:30 +0200
Re: [PATCH v2 2/3] xen-blkfront: introduce blkif_set_queue_limits() Roger Pau Monné <roger.pau@citrix.com> - 2016-07-27 12:50 +0200
[PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources Bob Liu <bob.liu@oracle.com> - 2016-07-26 07:30 +0200
Re: [PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources Roger Pau Monné <roger.pau@citrix.com> - 2016-07-26 10:50 +0200
Re: [PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources Bob Liu <bob.liu@oracle.com> - 2016-07-26 11:00 +0200
Re: [PATCH v2 3/3] xen-blkfront: dynamic configuration of per-vbd resources Roger Pau Monné <roger.pau@citrix.com> - 2016-07-26 18:00 +0200
Re: [PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-07-28 03:30 +0200
Re: [PATCH 1/3] xen-blkfront: fix places not updated after introducing 64KB page granularity Bob Liu <bob.liu@oracle.com> - 2016-07-28 11:10 +0200
csiph-web