Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1451794

[PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

From Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue
Date 2016-07-28 10:30 +0200
Message-ID <rZORz-3Ef-1@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


A dedicated workqueue has been used since the work items are being used
on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward
progress under memory pressure.

The workqueue has a single work item. Hence, alloc_workqueue() is used
instead of alloc_ordered_workqueue() since ordering is unnecessary when
there's only one work item.

Explicit concurrency limit is unnecessary here since there are only a
fixed number of work items.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c b/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
index 9eeee05..7c85262 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
@@ -552,7 +552,8 @@ void mlx5_pagealloc_cleanup(struct mlx5_core_dev *dev)

 int mlx5_pagealloc_start(struct mlx5_core_dev *dev)
 {
-	dev->priv.pg_wq = create_singlethread_workqueue("mlx5_page_allocator");
+	dev->priv.pg_wq = alloc_workqueue("mlx5_page_allocator",
+					  WQ_MEM_RECLAIM, 0);
 	if (!dev->priv.pg_wq)
 		return -ENOMEM;

--
2.1.4

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] net/mlx5_core/pagealloc: Remove deprecated  create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-07-28 10:30 +0200
  Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-07-28 11:40 +0200
    Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue Saeed Mahameed <saeedm@dev.mellanox.co.il> - 2016-07-29 00:50 +0200
    Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated  create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-07-29 14:30 +0200
      Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-07-31 09:00 +0200
        Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated  create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-08-01 17:20 +0200
          Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated  create_singlethread_workqueue Leon Romanovsky <leonro@mellanox.com> - 2016-08-02 08:00 +0200
  Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue Saeed Mahameed <saeedm@dev.mellanox.co.il> - 2016-07-29 00:50 +0200

csiph-web