RE: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process

From	"Li, Liang Z" <liang.z.li@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process
Date	2016-07-28 05:50 +0200
Message-ID	<rZKuB-vE-5@gated-at.bofh.it> (permalink)
References	<rZlZf-1d6-3@gated-at.bofh.it> <rZlZf-1d6-1@gated-at.bofh.it> <rZFbA-5js-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> > +/*
> > + * VIRTIO_BALLOON_PFNS_LIMIT is used to limit the size of page bitmap
> > + * to prevent a very large page bitmap, there are two reasons for this:
> > + * 1) to save memory.
> > + * 2) allocate a large bitmap may fail.
> > + *
> > + * The actual limit of pfn is determined by:
> > + * pfn_limit = min(max_pfn, VIRTIO_BALLOON_PFNS_LIMIT);
> > + *
> > + * If system has more pages than VIRTIO_BALLOON_PFNS_LIMIT, we will
> > +scan
> > + * the page list and send the PFNs with several times. To reduce the
> > + * overhead of scanning the page list. VIRTIO_BALLOON_PFNS_LIMIT
> > +should
> > + * be set with a value which can cover most cases.
> > + */
> > +#define VIRTIO_BALLOON_PFNS_LIMIT ((32 * (1ULL << 30)) >>
> PAGE_SHIFT)
> > +/* 32GB */
> > +
> >  static int oom_pages = OOM_VBALLOON_DEFAULT_PAGES;
> > module_param(oom_pages, int, S_IRUSR | S_IWUSR);
> > MODULE_PARM_DESC(oom_pages, "pages to free on OOM");
> >
> > +extern unsigned long get_max_pfn(void);
> > +
> 
> Please just include the correct header. No need for this hackery.
> 

Will change. Thanks!

Liang

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate process Liang Li <liang.z.li@intel.com> - 2016-07-27 03:40 +0200
  Re: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate  process Dave Hansen <dave.hansen@intel.com> - 2016-07-27 18:10 +0200
    Re: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate  process "Michael S. Tsirkin" <mst@redhat.com> - 2016-07-27 23:40 +0200
      RE: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate  process "Li, Liang Z" <liang.z.li@intel.com> - 2016-07-28 05:40 +0200
        Re: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate  process "Michael S. Tsirkin" <mst@redhat.com> - 2016-07-29 00:20 +0200
          RE: [virtio-dev] Re: [PATCH v2 repost 4/7] virtio-balloon: speed up  inflate/deflate process "Li, Liang Z" <liang.z.li@intel.com> - 2016-07-29 03:10 +0200
    RE: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate  process "Li, Liang Z" <liang.z.li@intel.com> - 2016-07-28 03:20 +0200
      Re: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate  process "Michael S. Tsirkin" <mst@redhat.com> - 2016-07-28 03:50 +0200
        RE: [virtio-dev] Re: [PATCH v2 repost 4/7] virtio-balloon: speed up  inflate/deflate process "Li, Liang Z" <liang.z.li@intel.com> - 2016-07-28 08:40 +0200
          Re: [virtio-dev] Re: [PATCH v2 repost 4/7] virtio-balloon: speed up  inflate/deflate process "Michael S. Tsirkin" <mst@redhat.com> - 2016-07-29 00:00 +0200
            RE: [virtio-dev] Re: [PATCH v2 repost 4/7] virtio-balloon: speed up  inflate/deflate process "Li, Liang Z" <liang.z.li@intel.com> - 2016-07-29 02:50 +0200
            Re: [virtio-dev] Re: [PATCH v2 repost 4/7] virtio-balloon: speed up  inflate/deflate process Dave Hansen <dave.hansen@intel.com> - 2016-07-29 21:50 +0200
              RE: [virtio-dev] Re: [PATCH v2 repost 4/7] virtio-balloon: speed up  inflate/deflate process "Li, Liang Z" <liang.z.li@intel.com> - 2016-08-02 02:40 +0200
  Re: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate  process "Michael S. Tsirkin" <mst@redhat.com> - 2016-07-27 23:40 +0200
    RE: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate  process "Li, Liang Z" <liang.z.li@intel.com> - 2016-07-28 05:10 +0200
      Re: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate  process "Michael S. Tsirkin" <mst@redhat.com> - 2016-07-29 00:20 +0200
        RE: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate  process "Li, Liang Z" <liang.z.li@intel.com> - 2016-07-29 02:40 +0200
  Re: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate  process "Michael S. Tsirkin" <mst@redhat.com> - 2016-07-28 00:10 +0200
    RE: [PATCH v2 repost 4/7] virtio-balloon: speed up inflate/deflate  process "Li, Liang Z" <liang.z.li@intel.com> - 2016-07-28 05:50 +0200

csiph-web