Re: [PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for Control mode page

From	Tom Yan <tom.ty89@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for Control mode page
Date	2016-07-27 23:10 +0200
Message-ID	<rZEfw-4Gp-21@gated-at.bofh.it> (permalink)
References	(3 earlier) <rXrcJ-2T6-11@gated-at.bofh.it> <rXrcJ-2T6-5@gated-at.bofh.it> <rXtHA-4Eb-25@gated-at.bofh.it> <rXuaC-4P9-7@gated-at.bofh.it> <rYSXg-7Yy-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Yes, because it touches an actual ATA drive setting, while D_SENSE is
merely a "software setting" stored in dev->flags to make the kernel
response differently when build sense data.

On 26 July 2016 at 02:30, Tejun Heo <tj@kernel.org> wrote:
> On Fri, Jul 22, 2016 at 05:50:18AM +0800, Tom Yan wrote:
>> As I've mentioned in the comment/message, there is no ATA command
>> needed to be sent to the device, since it only toggles a bit in
>> dev->flags. See that there is no ata_taskfile constructed in
>> ata_mselect_control().
>
> But ata_mselect_caching() contructs a tf?
>
> --
> tejun

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for  Control mode page Tom Yan <tom.ty89@gmail.com> - 2016-07-27 23:10 +0200

csiph-web