Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1451411

Re: [PATCH] perf sched: fix wrong conversion of task state

From David Ahern <dsahern@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] perf sched: fix wrong conversion of task state
Date 2016-07-27 19:00 +0200
Message-ID <rZAlA-1Uf-5@gated-at.bofh.it> (permalink)
References <rZwUF-8kd-3@gated-at.bofh.it> <rZxQJ-ug-11@gated-at.bofh.it> <rZzzb-1Cb-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 7/27/16 9:58 AM, 関山友輝 / SEKIYAMA，TOMOKI wrote:
>>> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
>>> index 0dfe8df..eb2f7f4 100644
>>> --- a/tools/perf/builtin-sched.c
>>> +++ b/tools/perf/builtin-sched.c
>>> @@ -71,6 +71,7 @@ struct sched_atom {
>>>  };
>>>
>>>  #define TASK_STATE_TO_CHAR_STR "RSDTtZXxKWP"
>>> +#define TASK_STATE_MASK 0x7ff
>>
>> The mask should not be needed and looking at top of tree there are 2 new
>> states (N and n) that need to be added.
>
> I couldn't find the state for 'n'. Where can I find it?

Check Linus' tree -- top of tree; commit 7dc603c9028ea.


> I have rechecked the code and found that __trace_sched_switch_state() uses
> TASK_STATE_MAX for preempted tasks.

since TASK_STATE_MAX is kernel version dependent perf should not rely on it.

> I will add 'N', and '+' (instead of "R+" ftrace shows) for preempted tasks.
> (Also add_sched_out_event should set THREAD_WAIT_CPU for preempted tasks.)
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf sched: fix wrong conversion of task state Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com> - 2016-07-27 15:20 +0200
  Re: [PATCH] perf sched: fix wrong conversion of task state David Ahern <dsahern@gmail.com> - 2016-07-27 16:20 +0200
    RE: [PATCH] perf sched: fix wrong conversion of task state 関山友輝 / SEKIYAMA，TOMOKI   <tomoki.sekiyama.qu@hitachi.com> - 2016-07-27 18:10 +0200
    RE: [PATCH] perf sched: fix wrong conversion of task state 関山友輝 / SEKIYAMA，TOMOKI   <tomoki.sekiyama.qu@hitachi.com> - 2016-07-27 18:10 +0200
      Re: [PATCH] perf sched: fix wrong conversion of task state David Ahern <dsahern@gmail.com> - 2016-07-27 19:00 +0200
        RE: [PATCH] perf sched: fix wrong conversion of task state "Tomoki Sekiyama" <tomoki.sekiyama.qu@hitachi.com> - 2016-07-28 05:20 +0200
          Re: [PATCH] perf sched: fix wrong conversion of task state David Ahern <dsahern@gmail.com> - 2016-07-28 16:30 +0200
            Re: [PATCH] perf sched: fix wrong conversion of task state 関山友輝 / SEKIYAMA，TOMOKI   <tomoki.sekiyama.qu@hitachi.com> - 2016-07-29 04:40 +0200

csiph-web