Re: [PATCH 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Heiko Stübner <heiko@sntech.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it
Date	Tue, 26 Jul 2016 11:20:02 +0200
Message-ID	<rZ6GS-8I-31@gated-at.bofh.it> (permalink)
References	<rZ3SF-6Uk-7@gated-at.bofh.it>
User-Agent	KMail/4.14.10 (Linux/4.6.0-1-amd64; KDE/4.14.21; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	jic23@kernel.org, robh+dt@kernel.org, linux-iio@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux@roeck-us.net, dianders@chromium.org
X-Original-Date	Tue, 26 Jul 2016 11:17:34 +0200
X-Original-Message-ID	<12149198.2BnIdx96cc@diego>
X-Original-References	<1469513510-1516-1-git-send-email-wxt@rock-chips.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1450495

Show key headers only | View raw

Am Dienstag, 26. Juli 2016, 14:11:47 schrieb Caesar Wang:
> SARADC controller needs to be reset before programming it, otherwise
> it will not function properly.
> 
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: linux-iio@vger.kernel.org
> Cc: linux-rockchip@lists.infradead.org
> ---
> 
>  .../bindings/iio/adc/rockchip-saradc.txt           |  5 +++++
>  drivers/iio/adc/Kconfig                            |  1 +
>  drivers/iio/adc/rockchip_saradc.c                  | 22
> ++++++++++++++++++++++ 3 files changed, 28 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
> b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt index
> bf99e2f..d2258be 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt
> @@ -13,6 +13,9 @@ Required properties:
>  - clocks: Must contain an entry for each entry in clock-names.
>  - clock-names: Shall be "saradc" for the converter-clock, and "apb_pclk"
> for the peripheral clock.
> +- resets: Must contain an entry for each entry in reset-names.
> +	  See ../reset/reset.txt for details.
> +- reset-names: Must include the name "saradc-apb".

as pointed out by John, this should be an optional property, as it should work 
with old devicetrees as well.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it Caesar Wang <wxt@rock-chips.com> - 2016-07-26 08:20 +0200
  [PATCH 2/4] arm64: dts: rockchip: add the saradc for rk3399 Caesar Wang <wxt@rock-chips.com> - 2016-07-26 08:20 +0200
  Re: [PATCH 1/4] iio: adc: rockchip_saradc: reset saradc controller  before programming it John Keeping <john@metanate.com> - 2016-07-26 11:10 +0200
    Re: [PATCH 1/4] iio: adc: rockchip_saradc: reset saradc controller  before programming it Caesar Wang <wxt@rock-chips.com> - 2016-07-26 13:00 +0200
      Re: [PATCH 1/4] iio: adc: rockchip_saradc: reset saradc controller  before programming it John Keeping <john@metanate.com> - 2016-07-26 13:20 +0200
  Re: [PATCH 1/4] iio: adc: rockchip_saradc: reset saradc controller before programming it Heiko Stübner <heiko@sntech.de> - 2016-07-26 11:20 +0200

csiph-web