Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1449192

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

Show all headers | View raw

On Sun, Jul 24, 2016 at 07:45:13PM +0200, Christian Lamparter wrote:

> > The symptom is that downloaded files (http, ftp, and probably other
> > protocols) have small corrupted segments (about 1-2 kilobytes long) in
> > random locations. Only downloads that sustain a high speed for at least a
> > few seconds are corrupted. Anything small enough to be received in less
> > than about 5 seconds is not affected.

Can that sucker be reproduced with netcat?  That would eliminate all issues
with multi-iovec recvmsg(2), narrowing the things down quite bit.

Another thing (and if that works, it's *NOT* a proper fix - it would be
papering over the problem, but at least it would show where to look for
it) - try (on top of mainline) the following delta:

diff --git a/net/core/datagram.c b/net/core/datagram.c
index b7de71f..0ee5995 100644
--- a/net/core/datagram.c
+++ b/net/core/datagram.c
@@ -734,7 +734,7 @@ int skb_copy_and_csum_datagram_msg(struct sk_buff *skb,
 	if (!chunk)
 		return 0;
 
-	if (msg_data_left(msg) < chunk) {
+	if (iov_iter_single_seg_count(&msg->msg_iter) < chunk) {
 		if (__skb_checksum_complete(skb))
 			goto csum_error;
 		if (skb_copy_datagram_msg(skb, hlen, msg, chunk))

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

PROBLEM: network data corruption (bisected to e5a4b0bb803b) Alan Curry <rlwinm@sdf.org> - 2016-07-24 05:50 +0200
  Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b) Christian Lamparter <chunkeey@googlemail.com> - 2016-07-24 19:50 +0200
    Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b) Al Viro <viro@ZenIV.linux.org.uk> - 2016-07-24 21:10 +0200

csiph-web