Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1449184
| From | Dave Watson <davejwatson@fb.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH v7 7/7] Restartable sequences: self-tests |
| Date | 2016-07-24 20:10 +0200 |
| Message-ID | <rYw0F-2FM-1@gated-at.bofh.it> (permalink) |
| References | <rXtxT-4A4-3@gated-at.bofh.it> <rXtxU-4A4-33@gated-at.bofh.it> <rYw0F-2FM-3@gated-at.bofh.it> <rYhXH-2zD-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
>> +static inline __attribute__((always_inline))
>> +bool rseq_finish(struct rseq_lock *rlock,
>> + intptr_t *p, intptr_t to_write,
>> + struct rseq_state start_value)
>> This ABI looks like it will work fine for our use case. I don't think it
>> has been mentioned yet, but we may still need multiple asm blocks
>> for differing numbers of writes. For example, an array-based freelist push:
>> void push(void *obj) {
>> if (index < maxlen) {
>> freelist[index++] = obj;
>> }
>> }
>> would be more efficiently implemented with a two-write rseq_finish:
>> rseq_finish2(&freelist[index], obj, // first write
>> &index, index + 1, // second write
>> ...);
> Would pairing one rseq_start with two rseq_finish do the trick
> there ?
Yes, two rseq_finish works, as long as the extra rseq management overhead
is not substantial.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH v7 0/7] Restartable sequences system call Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2016-07-21 23:20 +0200
[RFC PATCH v7 2/7] tracing: instrument restartable sequences Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2016-07-21 23:20 +0200
[RFC PATCH v7 1/7] Restartable sequences system call Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2016-07-21 23:20 +0200
[RFC PATCH v7 6/7] Restartable sequences: wire up x86 32/64 system call Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2016-07-21 23:20 +0200
Re: [RFC PATCH v7 7/7] Restartable sequences: self-tests Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2016-07-24 05:10 +0200
Re: [RFC PATCH v7 7/7] Restartable sequences: self-tests Dave Watson <davejwatson@fb.com> - 2016-07-24 20:10 +0200
Re: [RFC PATCH v7 7/7] Restartable sequences: self-tests Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2016-07-25 18:50 +0200
Re: [RFC PATCH v7 7/7] Restartable sequences: self-tests Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2016-07-25 20:20 +0200
csiph-web