Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1449135

Re: kexec: device shutdown vs. remove

From Benjamin Herrenschmidt <benh@kernel.crashing.org>
Newsgroups linux.kernel
Subject Re: kexec: device shutdown vs. remove
Date 2016-07-24 15:20 +0200
Message-ID <rYru1-8mY-9@gated-at.bofh.it> (permalink)
References <rYcbD-7kW-1@gated-at.bofh.it> <rYkiR-3Tz-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sun, 2016-07-24 at 00:24 -0500, Eric W. Biederman wrote:
> If you are willing to do the work to merge shutdown into remove and
> simplify the drivers, perform the testing and the other state I am in
> favor of the change.  I think we have had enough time to see if have two
> methods was maintainable for the driver authors.

Well, remove is going away in some drivers at least...

Also shutdown() has two different meaning between kexec and actual
machine shutdown...

Should we create a new one instead ? Something like quiesce() ? If
absent, look for remove(), if absent too, look for shutdown() ...

Or we continue doing shutdown() for now with a fallback to remove() if
shutdown is NULL (this is what I've been toying with internally).

Cheers,
ben.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

kexec: device shutdown vs. remove Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-07-23 23:00 +0200
  Re: kexec: device shutdown vs. remove Guenter Roeck <linux@roeck-us.net> - 2016-07-24 07:20 +0200
    Re: kexec: device shutdown vs. remove Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-07-24 15:20 +0200
      Re: kexec: device shutdown vs. remove ebiederm@xmission.com (Eric W. Biederman) - 2016-07-25 00:00 +0200
        Re: kexec: device shutdown vs. remove Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-07-25 02:40 +0200
  Re: kexec: device shutdown vs. remove ebiederm@xmission.com (Eric W. Biederman) - 2016-07-24 07:40 +0200
    Re: kexec: device shutdown vs. remove Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2016-07-24 15:20 +0200
      Re: kexec: device shutdown vs. remove ebiederm@xmission.com (Eric W. Biederman) - 2016-07-24 23:50 +0200

csiph-web