Re: [PATCH] cdrom: Delete an unnecessary check before unregister_sysctl_table()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cdrom: Delete an unnecessary check before unregister_sysctl_table()
Date	2016-07-24 11:50 +0200
Message-ID	<rYocN-6gG-3@gated-at.bofh.it> (permalink)
References	(13 earlier) <mSsDN-4wa-61@gated-at.bofh.it> <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <pKf46-69s-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 9 Jul 2015 09:52:24 +0200
> 
> The unregister_sysctl_table() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/cdrom/cdrom.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index 5d28a45..e43e84d 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -3698,8 +3698,7 @@ static void cdrom_sysctl_register(void)
>  
>  static void cdrom_sysctl_unregister(void)
>  {
> -	if (cdrom_sysctl_header)
> -		unregister_sysctl_table(cdrom_sysctl_header);
> +	unregister_sysctl_table(cdrom_sysctl_header);
>  }
>  
>  #else /* CONFIG_SYSCTL */
> 

How do you think about to integrate this update suggestion
into another source code repository?

Regards,
Markus

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] cdrom: Delete an unnecessary check before  unregister_sysctl_table() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-24 11:50 +0200

csiph-web