Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1449070

Re: [PATCH -next] xtensa: Fix build error due to missing include file

Show all headers | View raw

On 07/23/2016 05:45 PM, Max Filippov wrote:
> On Sun, Jul 24, 2016 at 3:24 AM, Guenter Roeck <linux@roeck-us.net> wrote:
>> Commit 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate
>> with default match table") dropped various include files from
>> arch/xtensa/kernel/setup.c. This results in the following build error.
>>
>> arch/xtensa/kernel/setup.c: In function ‘xtensa_dt_io_area’:
>> arch/xtensa/kernel/setup.c:213:2: error:
>>          implicit declaration of function ‘of_read_ulong’
>>
>> Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary of_platform_populate with default match table")
>> Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
>> Cc: Rob Herring <robh@kernel.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> I would suggest to merge this patch into the commit causing the problem
>> if possible.
>>
>>   arch/xtensa/kernel/setup.c | 1 +
>>   1 file changed, 1 insertion(+)
>
> Acked-by: Max Filippov <jcmvbkbc@gmail.com>
>

Heads up: xtensa images build after this patch, but the image that
previously failed to build (generic_kc705_defconfig) doesn't boot,
at least not with qemu. I don't know if this is caused by 69d99e6c0d621f
or by some other patch.

Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] xtensa: Fix build error due to missing include file Guenter Roeck <linux@roeck-us.net> - 2016-07-24 02:30 +0200
  Re: [PATCH -next] xtensa: Fix build error due to missing include file Max Filippov <jcmvbkbc@gmail.com> - 2016-07-24 02:50 +0200
    Re: [PATCH -next] xtensa: Fix build error due to missing include file Guenter Roeck <linux@roeck-us.net> - 2016-07-24 08:10 +0200
      Re: [PATCH -next] xtensa: Fix build error due to missing include file Max Filippov <jcmvbkbc@gmail.com> - 2016-07-24 16:30 +0200
        Re: [PATCH -next] xtensa: Fix build error due to missing include file Rob Herring <robh@kernel.org> - 2016-07-24 17:20 +0200
          Re: [PATCH -next] xtensa: Fix build error due to missing include file Guenter Roeck <linux@roeck-us.net> - 2016-07-24 18:30 +0200
            Re: [PATCH -next] xtensa: Fix build error due to missing include file Max Filippov <jcmvbkbc@gmail.com> - 2016-07-25 10:10 +0200
              Re: [PATCH -next] xtensa: Fix build error due to missing include file Rob Herring <robh@kernel.org> - 2016-07-25 15:30 +0200
                Re: [PATCH -next] xtensa: Fix build error due to missing include file Max Filippov <jcmvbkbc@gmail.com> - 2016-07-25 22:10 +0200
              Re: [PATCH -next] xtensa: Fix build error due to missing include file Guenter Roeck <linux@roeck-us.net> - 2016-07-25 23:00 +0200

csiph-web