Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1449001
| From | Andi Kleen <andi@firstfloor.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] mm: optimize copy_page_to/from_iter_iovec |
| Date | 2016-07-23 23:00 +0200 |
| Message-ID | <rYcbD-7kW-9@gated-at.bofh.it> (permalink) |
| References | <rXQ1r-2G8-11@gated-at.bofh.it> <rXQ1r-2G8-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Mikulas Patocka <mpatocka@redhat.com> writes:
> copy = min(bytes, iov->iov_len - skip);
>
> +#ifdef CONFIG_HIGHMEM
> if (!fault_in_pages_writeable(buf, copy)) {
If you use IS_ENABLED in the if here ...
> kunmap(page);
> +
> +#ifdef CONFIG_HIGHMEM
> done:
> +#endif
... you don't need this ifdef.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] mm patches Mikulas Patocka <mpatocka@redhat.com> - 2016-07-22 23:20 +0200
[PATCH 2/2] mm: optimize copy_page_to/from_iter_iovec Mikulas Patocka <mpatocka@redhat.com> - 2016-07-22 23:20 +0200
Re: [PATCH 2/2] mm: optimize copy_page_to/from_iter_iovec Andi Kleen <andi@firstfloor.org> - 2016-07-23 23:00 +0200
[PATCH 1/2] mm: add cond_resched to generic_swapfile_activate Mikulas Patocka <mpatocka@redhat.com> - 2016-07-22 23:20 +0200
Re: [PATCH 1/2] mm: add cond_resched to generic_swapfile_activate Michal Hocko <mhocko@kernel.org> - 2016-07-25 09:30 +0200
csiph-web