Re: [PATCH v4 1/2] bpf: Add bpf_probe_write BPF helper to be called in tracers (kprobes)

From	Alexei Starovoitov <alexei.starovoitov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/2] bpf: Add bpf_probe_write BPF helper to be called in tracers (kprobes)
Date	2016-07-23 21:40 +0200
Message-ID	<rYaWd-6H3-1@gated-at.bofh.it> (permalink)
References	<rXx8t-757-1@gated-at.bofh.it> <rXyed-7U7-3@gated-at.bofh.it> <rXFpo-46k-41@gated-at.bofh.it> <rXSFX-4iU-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 22, 2016 at 05:05:27PM -0700, Sargun Dhillon wrote:
> It was tested with the tracex7 program on x86-64.

it's my fault to start tracexN tradition that turned out to be
cumbersome, let's not continue it. Instead could you rename it
to something meaningful? Like test_probe_write_user ?
Right now it just prints client's peer address and human needs to
visually verify that probe_write_user actually happened, if you can
convert it into a test it will help a lot.
We were planning to convert all of the samples/bpf/ into tests,
so we can run them continuously.

btw, single patch re-submit will not be picked up. Please always
re-submit the whole patch set together.

> +static const struct bpf_func_proto *bpf_get_probe_write_proto(void) {
> +	pr_warn_once("*****************************************************\n");
> +	pr_warn_once("* bpf_probe_write_user: Experimental Feature in use *\n");
> +	pr_warn_once("* bpf_probe_write_user: Feature may corrupt memory  *\n");
> +	pr_warn_once("*****************************************************\n");
> +	pr_notice_ratelimited("bpf_probe_write_user: %s[%d] installing program with helper: it may corrupt user memory!",
> +	current->comm, task_pid_nr(current));

I thought we were argeeing on single pr_warn_ratelimited without banner ?

The rest looks good.
Thanks!

Thread

[PATCH v4 1/2] bpf: Add bpf_probe_write BPF helper to be called in  tracers (kprobes) Sargun Dhillon <sargun@sargun.me> - 2016-07-22 03:10 +0200
  Re: [PATCH v4 1/2] bpf: Add bpf_probe_write BPF helper to be called  in tracers (kprobes) Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-07-22 04:20 +0200
    Re: [PATCH v4 1/2] bpf: Add bpf_probe_write BPF helper to be called  in tracers (kprobes) Daniel Borkmann <daniel@iogearbox.net> - 2016-07-22 12:00 +0200
      Re: [PATCH v4 1/2] bpf: Add bpf_probe_write BPF helper to be called  in tracers (kprobes) Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-07-22 18:10 +0200
      Re: [PATCH v4 1/2] bpf: Add bpf_probe_write BPF helper to be called  in tracers (kprobes) Sargun Dhillon <sargun@sargun.me> - 2016-07-23 02:10 +0200
        Re: [PATCH v4 1/2] bpf: Add bpf_probe_write BPF helper to be called  in tracers (kprobes) Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-07-23 21:40 +0200
          Re: [PATCH v4 1/2] bpf: Add bpf_probe_write BPF helper to be called  in tracers (kprobes) Sargun Dhillon <sargun@sargun.me> - 2016-07-24 02:40 +0200
            Re: [PATCH v4 1/2] bpf: Add bpf_probe_write BPF helper to be called  in tracers (kprobes) Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2016-07-24 03:20 +0200

csiph-web