Re: [PATCH] i2c: i2c-cros-ec-tunnel: Reduce logging noise

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] i2c: i2c-cros-ec-tunnel: Reduce logging noise
Date	2016-07-25 22:50 +0200
Message-ID	<rYUZ3-Lt-5@gated-at.bofh.it> (permalink)
References	<rYUw2-B7-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> -	else if (resp->i2c_status & EC_I2C_STATUS_ERROR)
> +	else if (resp->i2c_status & EC_I2C_STATUS_NAK)
> +		return -ENXIO;
> +	else if (resp->i2c_status)
>  		return -EREMOTEIO;

Since you mentioned Documentation/i2c/fault-codes already: -EIO?

>  
>  	/* Other side could send us back fewer messages, but not more */
> @@ -223,7 +225,7 @@ static int ec_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg i2c_msgs[],
>  
>  	result = ec_i2c_parse_response(msg->data, i2c_msgs, &num);
>  	if (result < 0) {
> -		dev_err(dev, "Error parsing EC i2c message %d\n", result);
> +		dev_dbg(dev, "Error parsing EC i2c message %d\n", result);

For me, this message can go entirely, but I'll leave this up to you.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] i2c: i2c-cros-ec-tunnel: Reduce logging noise Guenter Roeck <linux@roeck-us.net> - 2016-07-25 22:20 +0200
  Re: [PATCH] i2c: i2c-cros-ec-tunnel: Reduce logging noise Wolfram Sang <wsa@the-dreams.de> - 2016-07-25 22:50 +0200

csiph-web