Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1449776

Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe

Show all headers | View raw

Am Montag, 25. Juli 2016, 12:39:00 schrieb Guenter Roeck:
> If the ADC is read for the first time, the caller gets a timeout error,
> and the kernel log shows
> 
> read channel() error: -110
> 
> The ADC may be enabled on boot, and needs to be explicitly disabled
> for a read sequence to work (otherwise there is no completion interrupt).
> Disaple it explicitly in the probe function.
> 
> Fixes: 44d6f2ef94f9 ("iio: adc: add driver for Rockchip saradc")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

in my tests I hadn't notices that issue before, but that is likely because the 
bootloaders I had didn't enable the saradc. Anyway, that looks definitly sane, 
so

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe Guenter Roeck <linux@roeck-us.net> - 2016-07-25 21:40 +0200
  Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on probe Heiko Stübner <heiko@sntech.de> - 2016-07-25 21:50 +0200
  Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on  probe Caesar Wang <wxt@rock-chips.com> - 2016-07-26 05:00 +0200
    Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on  probe Guenter Roeck <linux@roeck-us.net> - 2016-07-26 05:30 +0200
      Re: [PATCH] iio: adc: rockchip_saradc: Explicitly disable ADC on  probe Caesar Wang <wxt@rock-chips.com> - 2016-07-26 08:50 +0200

csiph-web