[PATCH] staging: ks7010: declare private functions static

From	Nicholas Mc Guire <hofrat@osadl.org>
Newsgroups	linux.kernel
Subject	[PATCH] staging: ks7010: declare private functions static
Date	2016-07-25 21:30 +0200
Message-ID	<rYTJD-8ug-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Private functions in ks_hostif.c can be declared static. 

Fixes: 13a9930d15b4 ("staging: ks7010: add driver from Nanonote extra-repository")

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---

Found by sparse

The build of ks_hostif.o generated the following sparse warnings:

CHECK   drivers/staging/ks7010/ks_hostif.c
drivers/staging/ks7010/ks_hostif.c:72:6: warning: symbol
'ks_wlan_hw_wakeup_task' was not declared. Should it be static?
drivers/staging/ks7010/ks_hostif.c:1512:6: warning: symbol
'hostif_infrastructure_set2_request' was not declared. Should it be static?

As both functions reported are private to this file it seems reasonable 
to declare them static.

Compile tested with: x86_64_defconfig + CONFIG_STAGING=y
CONFIG_MMC=m, CONFIG_KS7010=m

Patch is against 4.7-rc7 (localversion-next -next-20160725)

 drivers/staging/ks7010/ks_hostif.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index a8822fe..71b6ba2 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -69,7 +69,7 @@ inline u32 get_DWORD(struct ks_wlan_private *priv)
 	return data;
 }
 
-void ks_wlan_hw_wakeup_task(struct work_struct *work)
+static void ks_wlan_hw_wakeup_task(struct work_struct *work)
 {
 	struct ks_wlan_private *priv =
 	    container_of(work, struct ks_wlan_private, ks_wlan_wakeup_task);
@@ -1505,7 +1505,7 @@ void hostif_infrastructure_set_request(struct ks_wlan_private *priv)
 	ks_wlan_hw_tx(priv, pp, hif_align_size(sizeof(*pp)), NULL, NULL, NULL);
 }
 
-void hostif_infrastructure_set2_request(struct ks_wlan_private *priv)
+static void hostif_infrastructure_set2_request(struct ks_wlan_private *priv)
 {
 	struct hostif_infrastructure_set2_request_t *pp;
 	uint16_t capability;
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: ks7010: declare private functions static Nicholas Mc Guire <hofrat@osadl.org> - 2016-07-25 21:30 +0200
  Re: [PATCH] staging: ks7010: declare private functions static Wolfram Sang <wsa@the-dreams.de> - 2016-07-25 23:10 +0200
    Re: [PATCH] staging: ks7010: declare private functions static Nicholas Mc Guire <der.herr@hofr.at> - 2016-07-26 08:50 +0200
      Re: [PATCH] staging: ks7010: declare private functions static Nicholas Mc Guire <der.herr@hofr.at> - 2016-07-26 09:00 +0200
      Re: [PATCH] staging: ks7010: declare private functions static Wolfram Sang <wsa@the-dreams.de> - 2016-07-26 09:00 +0200

csiph-web