Re: [PATCH 6/6] spi: octeon: Add thunderx driver

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/6] spi: octeon: Add thunderx driver
Date	2016-07-25 18:30 +0200
Message-ID	<rYQVs-6No-37@gated-at.bofh.it> (permalink)
References	<rY2Fj-1J3-9@gated-at.bofh.it> <rY2Fk-1J3-23@gated-at.bofh.it> <rYyOS-4lY-7@gated-at.bofh.it> <rYQLM-6JY-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Jul 25, 2016 at 05:51:22PM +0200, Jan Glauber wrote:
> On Sun, Jul 24, 2016 at 10:04:52PM +0100, Mark Brown wrote:
> > On Sat, Jul 23, 2016 at 12:42:55PM +0200, Jan Glauber wrote:

> > > +#define PCI_DEVICE_ID_THUNDERX_SPI      0xa00b

> > > +static const struct pci_device_id thunderx_spi_pci_id_table[] = {
> > > +	{ PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVICE_ID_THUNDERX_SPI) },
> > > +	{ 0, }
> > > +};

> > The define for the device ID doesn't seem to be adding much here.

> I find it more readable instead of PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, 0xa00b),
> or did I miss your point?

No, that's my point - I find myself wondering why there's a define half
way down the file and what else is looking at the define other than the
location a few lines below.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 6/6] spi: octeon: Add thunderx driver Jan Glauber <jglauber@cavium.com> - 2016-07-23 12:50 +0200
  Re: [PATCH 6/6] spi: octeon: Add thunderx driver Mark Brown <broonie@kernel.org> - 2016-07-24 23:10 +0200
    Re: [PATCH 6/6] spi: octeon: Add thunderx driver Mark Brown <broonie@kernel.org> - 2016-07-25 18:20 +0200
      Re: [PATCH 6/6] spi: octeon: Add thunderx driver Mark Brown <broonie@kernel.org> - 2016-07-27 20:20 +0200
        Re: [PATCH 6/6] spi: octeon: Add thunderx driver Mark Brown <broonie@kernel.org> - 2016-07-27 21:10 +0200
    Re: [PATCH 6/6] spi: octeon: Add thunderx driver Mark Brown <broonie@kernel.org> - 2016-07-25 18:30 +0200

csiph-web