Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1449554
| From | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 1/2] [media] cx25821: Drop Freeing of Workqueue |
| Date | 2016-07-25 17:00 +0200 |
| Message-ID | <rYPwm-5P2-31@gated-at.bofh.it> (permalink) |
| References | <rYPwm-5P2-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Workqueues shouldn't be freed. destroy_workqueue should be used instead. destroy_workqueue safely destroys a workqueue and ensures that all pending work items are done before destroying the workqueue. Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> --- Changes in v2: None drivers/media/pci/cx25821/cx25821-audio-upstream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cx25821/cx25821-audio-upstream.c b/drivers/media/pci/cx25821/cx25821-audio-upstream.c index 68dbc2d..05bd957 100644 --- a/drivers/media/pci/cx25821/cx25821-audio-upstream.c +++ b/drivers/media/pci/cx25821/cx25821-audio-upstream.c @@ -242,7 +242,7 @@ void cx25821_stop_upstream_audio(struct cx25821_dev *dev) dev->_audioframe_count = 0; dev->_audiofile_status = END_OF_FILE; - kfree(dev->_irq_audio_queues); + destroy_workqueue(dev->_irq_audio_queues); dev->_irq_audio_queues = NULL; kfree(dev->_audiofilename); -- 2.1.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/2] Remove improper workqueue usage Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-07-25 17:00 +0200
[PATCH v2 1/2] [media] cx25821: Drop Freeing of Workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-07-25 17:00 +0200
Re: [PATCH v2 1/2] [media] cx25821: Drop Freeing of Workqueue Tejun Heo <tj@kernel.org> - 2016-07-25 21:10 +0200
[PATCH v2 2/2] [media] cx25821: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-07-25 17:10 +0200
csiph-web