Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1449479

Re: [PATCH] mmc: moxart: fix wait_for_completion_interruptible_timeout return variable type

Show all headers | View raw

On Mon, Jul 25, 2016 at 10:29:46AM +0200, Ulf Hansson wrote:
> On 24 July 2016 at 18:32, Nicholas Mc Guire <hofrat@osadl.org> wrote:
> > wait_for_completion_timeout_interruptible returns long not unsigned long
> > so dma_time, which is used exclusively here, is changed to long.
> >
> > Fixes: 1b66e94e6b99 ("mmc: moxart: Add MOXA ART SD/MMC driver")
> >
> > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> > ---
> >
> > API non-compliance was located by coccinelle
> >
> > This is mostly cosmetic since dma_time is not actually used for anything
> > at present, however if it ever were, then a signal received would be
> > interpreted as a large remaining jiffies left, which would be wrong.
> >
> > Compile tested with: moxart_defconfig + ARCH_MULTI_V4=y,
> > CONFIG_ARCH_MOXART=y, CONFIG_MMC_MOXART=y
> >
> > Patch is against 4.7.0-rc7 (localversion-next -next-20160724)
> >
> >  drivers/mmc/host/moxart-mmc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/moxart-mmc.c b/drivers/mmc/host/moxart-mmc.c
> > index 79905ce..2e5c25f 100644
> > --- a/drivers/mmc/host/moxart-mmc.c
> > +++ b/drivers/mmc/host/moxart-mmc.c
> > @@ -257,7 +257,7 @@ static void moxart_dma_complete(void *param)
> >  static void moxart_transfer_dma(struct mmc_data *data, struct moxart_host *host)
> >  {
> >         u32 len, dir_data, dir_slave;
> > -       unsigned long dma_time;
> > +       long dma_time;
> >         struct dma_async_tx_descriptor *desc = NULL;
> >         struct dma_chan *dma_chan;
> >
> > @@ -397,7 +397,7 @@ static void moxart_prepare_data(struct moxart_host *host)
> >  static void moxart_request(struct mmc_host *mmc, struct mmc_request *mrq)
> >  {
> >         struct moxart_host *host = mmc_priv(mmc);
> > -       unsigned long pio_time, flags;
> > +       long pio_time, flags;
> 
> This changes "flags" too. I don't think that is what you really want, right!?
> 
oops - sorry - my bad - looks like I first added the problem
and then "found it" - will fix this up.

thx!
hofrat

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mmc: moxart: fix wait_for_completion_interruptible_timeout return variable type Nicholas Mc Guire <hofrat@osadl.org> - 2016-07-24 18:30 +0200
  Re: [PATCH] mmc: moxart: fix wait_for_completion_interruptible_timeout  return variable type Ulf Hansson <ulf.hansson@linaro.org> - 2016-07-25 10:30 +0200
    Re: [PATCH] mmc: moxart: fix  wait_for_completion_interruptible_timeout return variable type Nicholas Mc Guire <der.herr@hofr.at> - 2016-07-25 15:30 +0200

csiph-web