Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in neigh_update()

From	吉藤英明 <hideaki.yoshifuji@miraclelinux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in neigh_update()
Date	2016-07-25 14:50 +0200
Message-ID	<rYNux-4Cm-7@gated-at.bofh.it> (permalink)
References	<rXDdT-2JE-9@gated-at.bofh.it> <rXI3T-5Un-1@gated-at.bofh.it> <rYGCJ-Bk-3@gated-at.bofh.it> <rYJhf-2dz-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

2016-07-25 17:13 GMT+09:00 Chunhui He <hchunhui@mail.ustc.edu.cn>:
>>> The NEIGH_UPDATE_F_WEAK_OVERRIDE is confusing to me, so I choose not to deal
>>> with the flag.
>>
>> IPv6 depends on WEAK_OVERRIDE.  Please do not change.
>>
>
> It seems like IPv6 always sets WEAK_OVERRIDE.
>

Yes.

> As Julian said, maybe there is no good reason to set NUD_STALE for any state
> that is NUD_VALID if address is not changed, even WEAK_OVERRIDE is not set.
> So we may eliminate WEAK_OVERRIDE in that branch.
>
> I think this change should not break IPv6.

OK, following blocks are "no-op" and we will get same result.

Well, please do not try changing several things at the same time and
you could say:

if (ladder == neigh->ha && new == NUD_STALE &&
    !(flags & NUD_UPDATE_F_ADMIN))
        new = old;

I think I tried to maintain our traditional IPv4 behavior (e.g. as of
2.2 era), BTW...

--yoshfuji

Thread

[PATCH] net: neigh: disallow state transition DELAY->STALE in neigh_update() Chunhui He <hchunhui@mail.ustc.edu.cn> - 2016-07-21 20:10 +0200
  Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in  neigh_update() Julian Anastasov <ja@ssi.bg> - 2016-07-22 09:40 +0200
    Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in  neigh_update() Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-07-22 11:50 +0200
    Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in  neigh_update() Chunhui He <hchunhui@mail.ustc.edu.cn> - 2016-07-22 14:50 +0200
      Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in  neigh_update() Julian Anastasov <ja@ssi.bg> - 2016-07-23 08:20 +0200
        Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in  neigh_update() Chunhui He <hchunhui@mail.ustc.edu.cn> - 2016-07-23 13:30 +0200
          Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in  neigh_update() Julian Anastasov <ja@ssi.bg> - 2016-07-23 16:20 +0200
            Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in  neigh_update() Chunhui He <hchunhui@mail.ustc.edu.cn> - 2016-07-23 19:00 +0200
              Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in  neigh_update() Julian Anastasov <ja@ssi.bg> - 2016-07-23 21:20 +0200
                Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in  neigh_update() Chunhui He <hchunhui@mail.ustc.edu.cn> - 2016-07-25 10:00 +0200
      Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in  neigh_update() YOSHIFUJI Hideaki/吉藤英明   <hideaki.yoshifuji@miraclelinux.com> - 2016-07-25 07:30 +0200
        Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in  neigh_update() Chunhui He <hchunhui@mail.ustc.edu.cn> - 2016-07-25 10:20 +0200
          Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in neigh_update() 吉藤英明 <hideaki.yoshifuji@miraclelinux.com> - 2016-07-25 14:50 +0200
            Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in  neigh_update() Julian Anastasov <ja@ssi.bg> - 2016-07-25 21:00 +0200

csiph-web