Re: [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}'

From	Oleg Drokin <green@linuxhacker.ru>
Newsgroups	linux.kernel
Subject	Re: [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,\|,<<,>>,&}'
Date	2016-07-23 20:10 +0200
Message-ID	<rY9x8-5Z5-19@gated-at.bofh.it> (permalink)
References	<rXYLn-7WF-7@gated-at.bofh.it> <rXYLo-7WF-37@gated-at.bofh.it> <rY946-5yC-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Jul 23, 2016, at 1:31 PM, Joe Perches wrote:

> On Sat, 2016-07-23 at 02:37 -0400, Oleg Drokin wrote:
>> From: Emoly Liu <emoly.liu@intel.com>
> 
> unrelated trivial notes:
> 
>> diff --git a/drivers/staging/lustre/lustre/obdecho/echo_internal.h b/drivers/staging/lustre/lustre/obdecho/echo_internal.h
> []
>> @@ -33,9 +33,9 @@
>>  
>>  /* The persistent object (i.e. actually stores stuff!) */
>>  #define ECHO_PERSISTENT_OBJID    1ULL
>> -#define ECHO_PERSISTENT_SIZE     ((__u64)(1<<20))
>> +#define ECHO_PERSISTENT_SIZE     ((__u64)(1 << 20))
> 
> This is generally an error-prone pattern as the cast is
> done after the shift.

Hm, indeed.

> Perhaps better is using a specific type
> 
> #define ECHO_PERSISTENT_SIZE		(1ULL << 20)

Yes, I guess this is a better way.

> And lustre seems to use types with unnecessary __ prefixes.

Need to see if this file is included in userspace where the __ is needed.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}' Oleg Drokin <green@linuxhacker.ru> - 2016-07-23 08:40 +0200
  Re: [PATCH 12/15] staging/lustre: Add spaces preferred around that  '{+,-,*,/,|,<<,>>,&}' Joe Perches <joe@perches.com> - 2016-07-23 19:40 +0200
    Re: [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}' Oleg Drokin <green@linuxhacker.ru> - 2016-07-23 20:10 +0200

csiph-web