Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq()

From	Steve Muckle <steve.muckle@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq()
Date	2016-07-22 02:50 +0200
Message-ID	<rXwP8-6ID-5@gated-at.bofh.it> (permalink)
References	(3 earlier) <rXsLv-405-1@gated-at.bofh.it> <rXsVb-43s-5@gated-at.bofh.it> <rXvzI-5X0-7@gated-at.bofh.it> <rXvJn-60q-3@gated-at.bofh.it> <rXvJn-60q-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jul 21, 2016 at 04:36:48PM -0700, Steve Muckle wrote:
> As another alternative, this could be caught in cpufreq driver
> initialization? I believe you suggested that originally, but I avoided
> it as I didn't want to have to implement resolve_freq() for every
> target() style driver. It sounds like there aren't many though.

Going back and checking I see I was thinking of your suggestion that
cpufreq_register_driver() check that only target() drivers offer a
resolve_freq() callback. I put a comment for this in cpufreq.h but not a
check - I could add a check in another patch if you like.

Long term as I was mentioning in the other thread I think it'd be good
if the current target() drivers were modified to supply resolve_freq(),
and that cpufreq_register_driver() were again changed to require it for
those drivers.

Thread

[PATCH v3 0/3] cpufreq: avoid redundant driver calls in schedutil Steve Muckle <steve.muckle@linaro.org> - 2016-07-13 22:30 +0200
  [PATCH v3 3/3] cpufreq: acpi-cpufreq: use cached frequency mapping when possible Steve Muckle <steve.muckle@linaro.org> - 2016-07-13 22:30 +0200
  [PATCH v3 2/3] cpufreq: schedutil: map raw required frequency to driver frequency Steve Muckle <steve.muckle@linaro.org> - 2016-07-13 22:30 +0200
  [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Steve Muckle <steve.muckle@linaro.org> - 2016-07-13 22:30 +0200
    Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Viresh Kumar <viresh.kumar@linaro.org> - 2016-07-21 22:00 +0200
      Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-21 22:30 +0200
        Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Viresh Kumar <viresh.kumar@linaro.org> - 2016-07-21 22:40 +0200
          Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-21 22:50 +0200
            Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Viresh Kumar <viresh.kumar@linaro.org> - 2016-07-21 23:00 +0200
              Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Viresh Kumar <viresh.kumar@linaro.org> - 2016-07-21 23:20 +0200
              Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-07-21 23:20 +0200
          Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Steve Muckle <steve.muckle@linaro.org> - 2016-07-22 01:30 +0200
            Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Viresh Kumar <viresh.kumar@linaro.org> - 2016-07-22 01:40 +0200
              Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Steve Muckle <steve.muckle@linaro.org> - 2016-07-22 01:40 +0200
                Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Steve Muckle <steve.muckle@linaro.org> - 2016-07-22 01:50 +0200
                Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Steve Muckle <steve.muckle@linaro.org> - 2016-07-22 02:50 +0200
                Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Viresh Kumar <viresh.kumar@linaro.org> - 2016-07-22 17:20 +0200
                Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Steve Muckle <steve.muckle@linaro.org> - 2016-07-22 19:50 +0200
            Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Viresh Kumar <viresh.kumar@linaro.org> - 2016-07-22 01:40 +0200
            Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Steve Muckle <steve.muckle@linaro.org> - 2016-07-22 01:40 +0200
    Re: [PATCH v3 1/3] cpufreq: add cpufreq_driver_resolve_freq() Viresh Kumar <viresh.kumar@linaro.org> - 2016-07-21 23:20 +0200
  Re: [PATCH v3 0/3] cpufreq: avoid redundant driver calls in schedutil Pingbo Wen <pingbo.wen@linaro.org> - 2016-07-14 12:10 +0200
    Re: [PATCH v3 0/3] cpufreq: avoid redundant driver calls in schedutil Steve Muckle <steve.muckle@linaro.org> - 2016-07-14 20:10 +0200
  Re: [PATCH v3 0/3] cpufreq: avoid redundant driver calls in schedutil Viresh Kumar <viresh.kumar@linaro.org> - 2016-07-21 22:10 +0200

csiph-web