Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1448203
| From | Tom Yan <tom.ty89@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for Control mode page |
| Date | 2016-07-22 00:00 +0200 |
| Message-ID | <rXuaC-4P9-7@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <rXrcJ-2T6-7@gated-at.bofh.it> <rXrcJ-2T6-9@gated-at.bofh.it> <rXrcJ-2T6-11@gated-at.bofh.it> <rXrcJ-2T6-5@gated-at.bofh.it> <rXtHA-4Eb-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
As I've mentioned in the comment/message, there is no ATA command
needed to be sent to the device, since it only toggles a bit in
dev->flags. See that there is no ata_taskfile constructed in
ata_mselect_control().
On 22 July 2016 at 05:26, Tejun Heo <tj@kernel.org> wrote:
> On Fri, Jul 22, 2016 at 02:41:54AM +0800, tom.ty89@gmail.com wrote:
>> @@ -3854,6 +3852,8 @@ static unsigned int ata_scsi_mode_select_xlat(struct ata_queued_cmd *qc)
>> if (ata_mselect_control(qc, p, pg_len, &fp) < 0) {
>> fp += hdr_len + bd_len;
>> goto invalid_param;
>> + } else {
>> + goto skip; /* No ATA command to send */
>
> Hmmm... I'm a bit confused. Why is mselect_control path different
> from mselect_caching in terms of qc handling?
>
> Thanks.
>
> --
> tejun
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for Control mode page tom.ty89@gmail.com - 2016-07-21 20:50 +0200
Re: [PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for Control mode page Tejun Heo <tj@kernel.org> - 2016-07-21 23:30 +0200
Re: [PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for Control mode page Tom Yan <tom.ty89@gmail.com> - 2016-07-22 00:00 +0200
Re: [PATCH resend 5/5] libata-scsi: fix MODE SELECT translation for Control mode page Tejun Heo <tj@kernel.org> - 2016-07-25 20:40 +0200
csiph-web