Re: [PATCH] efi: capsule: allocate whole capsule into virtual memory

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	"Christ, Austin" <austinwc@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] efi: capsule: allocate whole capsule into virtual memory
Date	Thu, 21 Jul 2016 23:10:02 +0200
Message-ID	<rXtoe-4vY-29@gated-at.bofh.it> (permalink)
References	<rVetj-No-19@gated-at.bofh.it> <rXm3o-7UG-21@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	61
Organization	linux.* mail to news gateway
X-Original-Cc	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jbrasen@codeaurora.org, Kweh Hock Leong <hock.leong.kweh@intel.com>, Bryan O'Donoghue <pure.logic@nexus-software.ie>
X-Original-Date	Thu, 21 Jul 2016 15:05:52 -0600
X-Original-Message-ID	<02d22437-2aaf-5eb1-d61d-2e7c9e68b081@codeaurora.org>
X-Original-References	<1468600891-15794-1-git-send-email-austinwc@codeaurora.org> <20160721131230.GH26504@codeblueprint.co.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1448146

Show key headers only | View raw

Hey Matt,


On 7/21/2016 7:12 AM, Matt Fleming wrote:
> On Fri, 15 Jul, at 10:41:31AM, Christ, Austin wrote:
>> According to UEFI 2.6 section 7.5.3, the capsule should be in contiguous
>> virtual memory and firmware may consume the capsule immediately. To
>> correctly implement this functionality, the kernel driver needs to vmap
>> the entire capsule at the time it is made available to firmware.
>>
>> The virtual allocation of the capsule update has been changed from kmap,
>> which was only allocating the first page of the update, to vmap and
>> allocates the entire data payload.
>>
>> Signed-off-by: Austin Christ <austinwc@codeaurora.org>
>> ---
>>   drivers/firmware/efi/capsule-loader.c | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/firmware/efi/capsule-loader.c b/drivers/firmware/efi/capsule-loader.c
>> index c99c24b..c4f3c20 100644
>> --- a/drivers/firmware/efi/capsule-loader.c
>> +++ b/drivers/firmware/efi/capsule-loader.c
>> @@ -16,6 +16,7 @@
>>   #include <linux/slab.h>
>>   #include <linux/mutex.h>
>>   #include <linux/efi.h>
>> +#include <linux/vmalloc.h>
>>   
>>   #define NO_FURTHER_WRITE_ACTION -1
>>   
>> @@ -108,14 +109,15 @@ static ssize_t efi_capsule_submit_update(struct capsule_info *cap_info)
>>   	int ret;
>>   	void *cap_hdr_temp;
>>   
>> -	cap_hdr_temp = kmap(cap_info->pages[0]);
>> +	cap_hdr_temp = vmap(cap_info->pages, cap_info->index,
>> +			VM_MAP, PAGE_KERNEL);
>>   	if (!cap_hdr_temp) {
>>   		pr_debug("%s: kmap() failed\n", __func__);
>>   		return -EFAULT;
>>   	}
>>   
>>   	ret = efi_capsule_update(cap_hdr_temp, cap_info->pages);
>> -	kunmap(cap_info->pages[0]);
>> +	vunmap(cap_hdr_temp);
>>   	if (ret) {
>>   		pr_err("%s: efi_capsule_update() failed\n", __func__);
>>   		return ret;
> Looks OK to me but could you also update the comments above
> efi_capsule_update() that mention the virtual mapping only being
> required for the first page?
That's a great point. The comments will be updated in v2.

> --
> To unsubscribe from this list: send the line "unsubscribe linux-efi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks,
Austin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] efi: capsule: allocate whole capsule into virtual memory Austin Christ <austinwc@codeaurora.org> - 2016-07-15 18:50 +0200
  Re: [PATCH] efi: capsule: allocate whole capsule into virtual memory Matt Fleming <matt@codeblueprint.co.uk> - 2016-07-21 15:20 +0200
    Re: [PATCH] efi: capsule: allocate whole capsule into virtual memory "Christ, Austin" <austinwc@codeaurora.org> - 2016-07-21 23:10 +0200

csiph-web