Re: [PATCH 13/13] rapidio/switches: add driver for IDT gen3 switches

From	Andrew Morton <akpm@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 13/13] rapidio/switches: add driver for IDT gen3 switches
Date	2016-07-21 21:10 +0200
Message-ID	<rXrw5-3fM-25@gated-at.bofh.it> (permalink)
References	<rXqJI-2G4-11@gated-at.bofh.it> <rXr34-2Nx-25@gated-at.bofh.it> <rXr34-2Nx-41@gated-at.bofh.it> <rXrw5-3fM-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 21 Jul 2016 18:48:17 +0000 "Bounine, Alexandre" <Alexandre.Bounine@idt.com> wrote:

> > > +		udelay(10);
> > > +		rio_write_config_32(rdev, RIO_PLM_SPx_IMP_SPEC_CTL(pnum),
> > rval);
> > > +		mdelay(500);
> > 
> > Yikes, that's a very long busywait.  A half-second machine freeze on
> > uniprocessor (if such exists ;)).  We can't use msleep()?
> > 
> 
> My bad ;) No problem with msleep() at all. We just need to give enough time
> for Rapidio link to get back (spec defines 500mS).
> Do you want a patch on patch? 

Patch on patch is good.  But something tested, please ;)

Thread

[PATCH 00/13] RapidIO subsystem updates Alexandre Bounine <alexandre.bounine@idt.com> - 2016-07-21 20:20 +0200
  [PATCH 08/13] rapidio: fix error handling in mbox request/release functions Alexandre Bounine <alexandre.bounine@idt.com> - 2016-07-21 20:30 +0200
  [PATCH 09/13] rapidio/idt_gen2: fix locking warning Alexandre Bounine <alexandre.bounine@idt.com> - 2016-07-21 20:30 +0200
  [PATCH 11/13] rapidio: modify for rev.3 specification changes Alexandre Bounine <alexandre.bounine@idt.com> - 2016-07-21 20:30 +0200
  [PATCH 12/13] powerpc/fsl_rio: apply changes for RIO spec rev 3 Alexandre Bounine <alexandre.bounine@idt.com> - 2016-07-21 20:30 +0200
  [PATCH 05/13] rapidio/tsi721: add PCIe MRRS override parameter Alexandre Bounine <alexandre.bounine@idt.com> - 2016-07-21 20:30 +0200
  [PATCH 06/13] rapidio/tsi721: add messaging mbox selector parameter Alexandre Bounine <alexandre.bounine@idt.com> - 2016-07-21 20:30 +0200
  [PATCH 01/13] rapidio: Remove unnecessary 0x prefixes before %pa extension uses Alexandre Bounine <alexandre.bounine@idt.com> - 2016-07-21 20:30 +0200
  Re: [PATCH 13/13] rapidio/switches: add driver for IDT gen3  switches Andrew Morton <akpm@linux-foundation.org> - 2016-07-21 20:40 +0200
    RE: [PATCH 13/13] rapidio/switches: add driver for IDT gen3 switches "Bounine, Alexandre" <Alexandre.Bounine@idt.com> - 2016-07-21 21:10 +0200
      Re: [PATCH 13/13] rapidio/switches: add driver for IDT gen3  switches Andrew Morton <akpm@linux-foundation.org> - 2016-07-21 21:10 +0200
  [PATCH 13/13] rapidio/switches: add driver for IDT gen3 switches Alexandre Bounine <alexandre.bounine@idt.com> - 2016-07-21 20:40 +0200
  [PATCH 10/13] rapidio: change inbound window size type to u64 Alexandre Bounine <alexandre.bounine@idt.com> - 2016-07-21 20:40 +0200

csiph-web