Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1448037

Re: [PATCH] net: bridge: br_set_ageing_time takes a clock_t

Show all headers | View raw

Hi Cong,

Cong Wang <xiyou.wangcong@gmail.com> writes:

> On Thu, Jul 21, 2016 at 9:42 AM, Vivien Didelot
> <vivien.didelot@savoirfairelinux.com> wrote:
>> Change the ageing_time type in br_set_ageing_time() from u32 to what it
>> is expected to be, i.e. a clock_t.
>
> You also need to change struct switchdev_attr:
>
> struct switchdev_attr {
>         struct net_device *orig_dev;
>         enum switchdev_attr_id id;
>         u32 flags;
>         void *complete_priv;
>         void (*complete)(struct net_device *dev, int err, void *priv);
>         union {
>                 struct netdev_phys_item_id ppid;        /* PORT_PARENT_ID */
>                 u8 stp_state;                           /* PORT_STP_STATE */
>                 unsigned long brport_flags;             /* PORT_BRIDGE_FLAGS */
>                 u32 ageing_time;                        /* BRIDGE_AGEING_TIME */
>                 bool vlan_filtering;                    /*
> BRIDGE_VLAN_FILTERING */
>         } u;
> };

Already changed in net/master as of eabfdda93477
("net: switchdev: change ageing_time type to clock_t").

Thanks,

        Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: bridge: br_set_ageing_time takes a clock_t Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-07-21 18:50 +0200
  Re: [PATCH] net: bridge: br_set_ageing_time takes a clock_t Cong Wang <xiyou.wangcong@gmail.com> - 2016-07-21 19:00 +0200
    Re: [PATCH] net: bridge: br_set_ageing_time takes a clock_t Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-07-21 20:20 +0200
      Re: [PATCH] net: bridge: br_set_ageing_time takes a clock_t Cong Wang <xiyou.wangcong@gmail.com> - 2016-07-21 20:30 +0200
  Re: [PATCH] net: bridge: br_set_ageing_time takes a clock_t David Miller <davem@davemloft.net> - 2016-07-25 19:40 +0200

csiph-web