Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1447929

Re: linux-next: build warnings after merge of the libata tree

Show all headers | View raw

Hello, Stephen.

On Thu, Jul 21, 2016 at 03:26:03PM +1000, Stephen Rothwell wrote:
> Hi Tejun,
> 
> After merging the libata tree, today's linux-next build (arm
> multi_v7_defconfig) produced these warning:
> 
> drivers/ata/libata-scsi.c: In function 'ata_mselect_caching':
> drivers/ata/libata-scsi.c:3637:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
>     if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
>                             ^
> drivers/ata/libata-scsi.c: In function 'ata_mselect_control':
> drivers/ata/libata-scsi.c:3702:28: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses]
>     if (mpage[i + 2] & 0xfb != buf[i] & 0xfb) {
>                             ^
> 
> Introduced by commit
> 
>   9b7844a8c34a ("libata-scsi: fix read-only bits checking in ata_mselect_*()")

Already reverted the patch.  Sorry about that.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

linux-next: build warnings after merge of the libata tree Stephen Rothwell <sfr@canb.auug.org.au> - 2016-07-21 07:30 +0200
  Re: linux-next: build warnings after merge of the libata tree Tejun Heo <tj@kernel.org> - 2016-07-21 16:50 +0200

csiph-web