Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1447916

Re: [PATCH v4] sched/deadline: remove useless param from setup_new_dl_entity

From Juri Lelli <juri.lelli@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH v4] sched/deadline: remove useless param from setup_new_dl_entity
Date 2016-07-21 16:30 +0200
Message-ID <rXn97-89-9@gated-at.bofh.it> (permalink)
References <rUq3v-1YL-13@gated-at.bofh.it> <rV8Hg-5Li-27@gated-at.bofh.it> <rWgt3-6Eh-17@gated-at.bofh.it> <rWgW5-6NT-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi,

On 18/07/16 21:37, Xunlei Pang wrote:
> On 2016/07/18 at 21:04, Juri Lelli wrote:
> > On 15/07/16 18:39, Xunlei Pang wrote:
> >> On 2016/07/13 at 18:58, Juri Lelli wrote:
> > [...]
> >
> >> Since this is only called for queued cases now, there is no need to
> >> check boosted stuff here. As enqueue_task(ENQUEUE_REPLENISH)
> >> is called before check_class_changed() in rt_mutex_setprio().
> >>
> > But we don't do the same in setscheduler, right?
> 
> If p is deadline PI-boosted, setscheduler() won't call change its sched_class.
> If p isn't deadline PI-boosted, then pi_task is NULL.
> 
> So, I think the added code won't hit. Did I miss something?
> 

No, I think you are right.

I'll shoot a v5 ASAP (I think I'll put a WARN_ON just in case).

Best,

- Juri

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4] sched/deadline: remove useless param from setup_new_dl_entity Juri Lelli <juri.lelli@arm.com> - 2016-07-13 13:00 +0200
  Re: [PATCH v4] sched/deadline: remove useless param from  setup_new_dl_entity Xunlei Pang <xpang@redhat.com> - 2016-07-15 12:40 +0200
    Re: [PATCH v4] sched/deadline: remove useless param from  setup_new_dl_entity Juri Lelli <juri.lelli@arm.com> - 2016-07-18 15:10 +0200
      Re: [PATCH v4] sched/deadline: remove useless param from  setup_new_dl_entity Xunlei Pang <xpang@redhat.com> - 2016-07-18 15:40 +0200
        Re: [PATCH v4] sched/deadline: remove useless param from  setup_new_dl_entity Juri Lelli <juri.lelli@arm.com> - 2016-07-21 16:30 +0200
          Re: [PATCH v4] sched/deadline: remove useless param from  setup_new_dl_entity Juri Lelli <juri.lelli@arm.com> - 2016-07-21 16:40 +0200
            Re: [PATCH v4] sched/deadline: remove useless param from  setup_new_dl_entity Juri Lelli <juri.lelli@arm.com> - 2016-07-21 16:50 +0200
              Re: [PATCH v4] sched/deadline: remove useless param from  setup_new_dl_entity Xunlei Pang <xpang@redhat.com> - 2016-07-22 05:00 +0200

csiph-web