Re: [PATCH 4/6] rtc: rv8803: Always apply the I²C workaround

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/6] rtc: rv8803: Always apply the I²C workaround
Date	2016-07-21 13:20 +0200
Message-ID	<rXkbg-6I6-13@gated-at.bofh.it> (permalink)
References	<rXjIe-6iZ-7@gated-at.bofh.it> <rXjIf-6iZ-61@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 21/07/2016 at 12:41:30 +0200, Benoît Thébaudeau wrote :
> The I²C NACK issue of the RV-8803 may occur after any I²C START
> condition, depending on the timings. Consequently, the workaround must
> be applied for all the I²C transfers.
> 
> This commit abstracts the I²C transfer code into register access
> functions. This avoids duplicating the I²C workaround everywhere. This
> also avoids the duplication of the code handling the return value of
> i2c_smbus_read_i2c_block_data(). Error messages are issued in case of
> definitive register access failures (if the workaround fails). This
> change also makes the I²C transfer return value checks consistent.
> 

Well, my initial idea was that the workaround is actually needed only
for operations that are not restartable from userspace.

Did you it that bug? On which RTC?

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

[PATCH 1/6] rtc: rv8803: Kconfig: Indicate rx8900 support Benoît Thébaudeau <benoit@wsystem.com> - 2016-07-21 12:50 +0200
  [PATCH 4/6] rtc: rv8803: Always apply the I²C workaround Benoît Thébaudeau <benoit@wsystem.com> - 2016-07-21 12:50 +0200
    Re: [PATCH 4/6] rtc: rv8803: Always apply the I²C workaround Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-07-21 13:20 +0200
      Re: [PATCH 4/6] rtc: rv8803: Always apply the I²C workaround Benoît Thébaudeau <benoit@wsystem.com> - 2016-07-21 14:40 +0200
      Re: [PATCH 4/6] rtc: rv8803: Always apply the I²C workaround Benoît Thébaudeau <benoit@wsystem.com> - 2016-07-21 20:50 +0200

csiph-web