Re: "coupled" regulator support

From	Jisheng Zhang <jszhang@marvell.com>
Newsgroups	linux.kernel
Subject	Re: "coupled" regulator support
Date	2016-07-21 13:00 +0200
Message-ID	<rXjRU-6ms-13@gated-at.bofh.it> (permalink)
References	<rVa6l-6K7-3@gated-at.bofh.it> <rVaSL-70X-31@gated-at.bofh.it> <rWaxk-2J5-13@gated-at.bofh.it> <rWl9n-1cd-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Dear Mark,

On Mon, 18 Jul 2016 19:05:08 +0100 Mark Brown wrote:

> On Mon, Jul 18, 2016 at 02:44:22PM +0800, Jisheng Zhang wrote:
> 
> > v1 and v2 and both valid voltages, but here we have an explicit limitation:
> > we must take the "regulator shared" fact into consideration. Let's assume
> > the voltage is at v2, devA is not busy now, it wants to scale down freq, then
> > scale down voltage to v1, but if devB hasn't call for setting voltage to
> > v1, we can't scale down voltage now, we need to wait for devB sending out
> > the voltage scaling down request when it is not busy in future some time.
> > Obviously, the last user will succeed to scale down the voltage.  
> 
> > My solution is
> > to extend regulator_check_consumers() to check whether all consumers agree
> > to scaling down voltage or not.  
> 
> I'm not sure I 100% follow your explanation above - it still sounds like
> a normal shared regulator situation.  In general I'm really unsure how

You are right!
After carefully checking the code, I found the existing regulator core could
meet my what I want.

Thanks so much,
Jisheng

> this sort of scheme is expected to work.  It seems like in a lot of
> cases there will be some other constraints in play (like needing to do
> frequency updates as part of the sequence) which can't be handled purely
> in the regulator API and/or that the DVFS driver ought to be able to use
> notifiers to discover when actual changes have happened and handle
> things in their own code.  But like I say I don't 100% follow what's new
> in your example so I may be missing something.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

"coupled" regulator support Jisheng Zhang <jszhang@marvell.com> - 2016-07-15 14:10 +0200
  Re: "coupled" regulator support Mark Brown <broonie@kernel.org> - 2016-07-15 15:00 +0200
    Re: "coupled" regulator support Jisheng Zhang <jszhang@marvell.com> - 2016-07-18 08:50 +0200
      Re: "coupled" regulator support Mark Brown <broonie@kernel.org> - 2016-07-18 20:10 +0200
        Re: "coupled" regulator support Jisheng Zhang <jszhang@marvell.com> - 2016-07-21 13:00 +0200

csiph-web