Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1447654

[PATCH] perf symbols: Fix reading build id

Show all headers | View raw

From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

When is_regular_file(name) is called name points to a freshly allocated
and uninitialized chunk of memory, so is_regular_file(name) is usually
false and reading build id is skipped which makes it impossible to
find debug infos when a build id based system is in use.

Fixes: 403567217d3f ("perf symbols: Do not read symbols/data from device files")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 tools/perf/util/symbol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 54c4ff2b1cee..7044742c828f 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1430,7 +1430,7 @@ int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter)
 	 * Read the build id if possible. This is required for
 	 * DSO_BINARY_TYPE__BUILDID_DEBUGINFO to work
 	 */
-	if (is_regular_file(name) &&
+	if (is_regular_file(dso->long_name) &&
 	    filename__read_build_id(dso->long_name, build_id, BUILD_ID_SIZE) > 0)
 		dso__set_build_id(dso, build_id);
 
-- 
2.8.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf symbols: Fix reading build id Uwe Kleine-König <uwe@kleine-koenig.org> - 2016-07-21 09:10 +0200
  Re: [PATCH] perf symbols: Fix reading build id Marc Kleine-Budde <mkl@pengutronix.de> - 2016-07-21 09:30 +0200
    Re: [PATCH] perf symbols: Fix reading build id Jiri Olsa <jolsa@redhat.com> - 2016-07-21 10:00 +0200
      Re: [PATCH] perf symbols: Fix reading build id Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-07-22 09:40 +0200

csiph-web