Re: [RFC 1/7] [media] rc-main: assign driver type during allocation

From	Andi Shyti <andi.shyti@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [RFC 1/7] [media] rc-main: assign driver type during allocation
Date	2016-07-21 02:30 +0200
Message-ID	<rXa2e-5t-11@gated-at.bofh.it> (permalink)
References	<rWFB7-5U4-7@gated-at.bofh.it> <rWFB8-5U4-9@gated-at.bofh.it> <rXa2e-5t-13@gated-at.bofh.it> <rWLnb-1hJ-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Sean,

> > The driver type can be assigned immediately when an RC device
> > requests to the framework to allocate the device.
> > 
> > This is an 'enum rc_driver_type' data type and specifies whether
> > the device is a raw receiver or scancode receiver. The type will
> > be given as parameter to the rc_allocate_device device.
> 
> This patch is good, but it does unfortunately break all the other
> rc-core drivers, as now rc_allocate_device() needs argument. All
> drivers will need a simple change in this patch.

Yes, but for being an RFC I didn't took care of fixing
everything.

> Also note that there lots of issues that checkpatch.pl would pick
> in these series.

Some of the issues are coming from the code as it was and I
preferred to not change it. The last patch has some that need to
be fixed in the patchset.

Thanks,
Andi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC 1/7] [media] rc-main: assign driver type during allocation Andi Shyti <andi.shyti@samsung.com> - 2016-07-19 18:00 +0200
  Re: [RFC 1/7] [media] rc-main: assign driver type during allocation Sean Young <sean@mess.org> - 2016-07-20 00:10 +0200
    Re: [RFC 1/7] [media] rc-main: assign driver type during allocation Andi Shyti <andi.shyti@samsung.com> - 2016-07-21 02:30 +0200

csiph-web