Re: [PATCH 2/5] mm: add per-zone lru list stat

From	Minchan Kim <minchan@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] mm: add per-zone lru list stat
Date	2016-07-23 03:30 +0200
Message-ID	<rXTVn-4WM-3@gated-at.bofh.it> (permalink)
References	<rX1BD-39C-7@gated-at.bofh.it> <rX1BD-39C-15@gated-at.bofh.it> <rXghj-4gp-9@gated-at.bofh.it> <rXTiF-4v0-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Fengguang,

On Sat, Jul 23, 2016 at 08:45:15AM +0800, Fengguang Wu wrote:
> Hi Minchan,
> 
> We find duplicate /proc/vmstat lines showing up in linux-next, which
> look related to this patch.
> 
> >>--- a/mm/vmstat.c
> >>+++ b/mm/vmstat.c
> >>@@ -921,6 +921,11 @@ int fragmentation_index(struct zone *zone, unsigned int order)
> >> const char * const vmstat_text[] = {
> >> 	/* enum zone_stat_item countes */
> >> 	"nr_free_pages",
> >>+	"nr_inactive_anon",
> >>+	"nr_active_anon",
> >>+	"nr_inactive_file",
> >>+	"nr_active_file",
> >>+	"nr_unevictable",
> >> 	"nr_mlock",
> >> 	"nr_slab_reclaimable",
> >> 	"nr_slab_unreclaimable",
> 
> In the below vmstat output, "nr_inactive_anon 2217" is shown twice.
> So do the other entries added by the above chunk.
> 
> nr_free_pages 831238
> nr_inactive_anon 2217
> nr_active_anon 4386
> nr_inactive_file 117467
> nr_active_file 4602
> nr_unevictable 0
> nr_zone_write_pending 0
> nr_mlock 0
> nr_slab_reclaimable 8323
> nr_slab_unreclaimable 4641
> nr_page_table_pages 870
> nr_kernel_stack 3776
> nr_bounce 0
> nr_zspages 0
> numa_hit 201105
> numa_miss 0
> numa_foreign 0
> numa_interleave 66970
> numa_local 201105
> numa_other 0
> nr_free_cma 0
> nr_inactive_anon 2217
> nr_active_anon 4368
> nr_inactive_file 117449
> nr_active_file 4620
> nr_unevictable 0
> nr_isolated_anon 0
> nr_isolated_file 0
> nr_pages_scanned 0
> workingset_refault 0
> workingset_activate 0
> workingset_nodereclaim 0
> nr_anon_pages 4321
> nr_mapped 3469
> nr_file_pages 124348
> nr_dirty 0
> nr_writeback 0
> nr_writeback_temp 0
> nr_shmem 2279
> nr_shmem_hugepages 0
> nr_shmem_pmdmapped 0

Thanks for catching that.
We need a decision to maintain LRU stat both per-zone and per-node.

Mel, do you want to keep the LRU stat in per-node in addition?

Thread

[PATCH 0/5] Candidate fixes for premature OOM kills with node-lru v1 Mel Gorman <mgorman@techsingularity.net> - 2016-07-20 17:30 +0200
  [PATCH 2/5] mm: add per-zone lru list stat Mel Gorman <mgorman@techsingularity.net> - 2016-07-20 17:30 +0200
    Re: [PATCH 2/5] mm: add per-zone lru list stat Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-07-21 09:10 +0200
      Re: [PATCH 2/5] mm: add per-zone lru list stat Fengguang Wu <fengguang.wu@intel.com> - 2016-07-23 02:50 +0200
        Re: [PATCH 2/5] mm: add per-zone lru list stat Minchan Kim <minchan@kernel.org> - 2016-07-23 03:30 +0200
  [PATCH 3/5] mm, vmscan: Remove highmem_file_pages Mel Gorman <mgorman@techsingularity.net> - 2016-07-20 17:30 +0200
  [PATCH 1/5] mm, vmscan: Do not account skipped pages as scanned Mel Gorman <mgorman@techsingularity.net> - 2016-07-20 17:30 +0200
    Re: [PATCH 1/5] mm, vmscan: Do not account skipped pages as scanned Minchan Kim <minchan@kernel.org> - 2016-07-21 07:20 +0200
      Re: [PATCH 1/5] mm, vmscan: Do not account skipped pages as scanned Mel Gorman <mgorman@techsingularity.net> - 2016-07-21 10:20 +0200
        Re: [PATCH 1/5] mm, vmscan: Do not account skipped pages as scanned Minchan Kim <minchan@kernel.org> - 2016-07-21 10:40 +0200
    Re: [PATCH 1/5] mm, vmscan: Do not account skipped pages as scanned Minchan Kim <minchan@kernel.org> - 2016-07-25 10:10 +0200
      Re: [PATCH 1/5] mm, vmscan: Do not account skipped pages as scanned Mel Gorman <mgorman@techsingularity.net> - 2016-07-25 11:30 +0200
  [PATCH 4/5] mm: Remove reclaim and compaction retry approximations Mel Gorman <mgorman@techsingularity.net> - 2016-07-20 17:30 +0200
  Re: [PATCH 0/5] Candidate fixes for premature OOM kills with  node-lru v1 Minchan Kim <minchan@kernel.org> - 2016-07-21 09:10 +0200
    Re: [PATCH 0/5] Candidate fixes for premature OOM kills with  node-lru v1 Mel Gorman <mgorman@techsingularity.net> - 2016-07-21 11:20 +0200
  Re: [PATCH 0/5] Candidate fixes for premature OOM kills with  node-lru v1 Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-07-21 09:30 +0200
    Re: [PATCH 0/5] Candidate fixes for premature OOM kills with  node-lru v1 Minchan Kim <minchan@kernel.org> - 2016-07-21 10:40 +0200
    Re: [PATCH 0/5] Candidate fixes for premature OOM kills with  node-lru v1 Mel Gorman <mgorman@techsingularity.net> - 2016-07-21 11:20 +0200

csiph-web