Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1448836
| Path | csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Markus Mayer <mmayer@broadcom.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH v4 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower() |
| Date | Sat, 23 Jul 2016 01:40:02 +0200 |
| Message-ID | <rXScW-3Uh-31@gated-at.bofh.it> (permalink) |
| References | <rXScV-3Uh-5@gated-at.bofh.it> |
| X-Original-To | Nicholas Bellinger <nab@linux-iscsi.org>, Roland Dreier <roland@purestorage.com>, Varun Prakash <varun@chelsio.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=B1TiZ/47MIThVnKR7afeMiYKu69k7xo4BVQsQcAIS68=; b=FLAMWpPbih1MNwU+z/EgrHI1OQCQn3zDb4OsaoRw0+BCrShTHfpx4EG7uI2hfMTiif iUSmK4oWjwSvQ0NvJRGOXj/G7lokyLpq6wNRlQEDA3brCLQVNzuprjDva9j/GExL+CtW COc2H4ysx45eXOpWVUUI/SFiBoygotFnbyN2o= |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=B1TiZ/47MIThVnKR7afeMiYKu69k7xo4BVQsQcAIS68=; b=NGTMk7G9YTrJMM43kjNqwgWBLh5X1KBZVr6PuiWTPKTA+Y6luVH1ZmYj4jI242LqjY vURmAdpK5uqNN1gIJckKpvgZFj59oOq6u0zi6cr3Av0Bdi9bFOwL6z7GETIr3VYRV69f pkv9lcRKKtPyCMFNcrimfjem0x+/qfvR5aKXmhczJRUsz/FYG130JPKxUxPZZPMGTIxS d4RzStplz6dpyGzpcF8KI+EjGEtfqfw9JfxtqNJ+LT85HaOCsr5HwGEu2QLonb+90k7N 4NcSjrb67wSVEsftlVG47mgtlQ8W6TjMdf6zZc5z5tF6/XRzdVqprxOqanRqNCtRMLIn tavQ== |
| X-Gm-Message-State | AEkoouuvjYcyR8MV/phfF6nLSqYtM2wu4QLT2Ui7ZSgh53r7n2ZeYlGDVkbwQmfwt4JJlmGH |
| X-Received | by 10.55.116.70 with SMTP id p67mr7664164qkc.150.1469230393032; Fri, 22 Jul 2016 16:33:13 -0700 (PDT) |
| X-Mailer | git-send-email 2.7.4 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 46 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Markus Mayer <mmayer@broadcom.com>, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org |
| X-Original-Date | Fri, 22 Jul 2016 16:31:07 -0700 |
| X-Original-Message-ID | <1469230269-1644-6-git-send-email-mmayer@broadcom.com> |
| X-Original-References | <1469230269-1644-1-git-send-email-mmayer@broadcom.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1448836 |
Show key headers only | View raw
After introducing generic strtolower(), iscsi_initiatorname_tolower() is
no longer needed.
Signed-off-by: Markus Mayer <mmayer@broadcom.com>
Acked-by: Nicholas Bellinger <nab@linux-iscsi.org>
---
drivers/target/iscsi/iscsi_target_nego.c | 17 +----------------
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
index 89d34bd..fa20638 100644
--- a/drivers/target/iscsi/iscsi_target_nego.c
+++ b/drivers/target/iscsi/iscsi_target_nego.c
@@ -987,21 +987,6 @@ static int iscsi_target_do_login(struct iscsi_conn *conn, struct iscsi_login *lo
return 0;
}
-static void iscsi_initiatorname_tolower(
- char *param_buf)
-{
- char *c;
- u32 iqn_size = strlen(param_buf), i;
-
- for (i = 0; i < iqn_size; i++) {
- c = ¶m_buf[i];
- if (!isupper(*c))
- continue;
-
- *c = tolower(*c);
- }
-}
-
/*
* Processes the first Login Request..
*/
@@ -1075,7 +1060,7 @@ int iscsi_target_locate_portal(
* RFC-3720 3.2.6.1. section c) that says that iSCSI IQNs
* are NOT case sensitive.
*/
- iscsi_initiatorname_tolower(i_buf);
+ strtolower(i_buf);
if (!s_buf) {
if (!login->leading_connection)
--
2.7.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 0/7] lib: string: add functions to case-convert strings Markus Mayer <mmayer@broadcom.com> - 2016-07-23 01:40 +0200
[PATCH v4 4/7] staging: speakup: replace spk_strlwr() with strlcpytolower() Markus Mayer <mmayer@broadcom.com> - 2016-07-23 01:40 +0200
Re: [PATCH v4 4/7] staging: speakup: replace spk_strlwr() with strlcpytolower() Chris Brannon <chris@the-brannons.com> - 2016-07-23 02:10 +0200
[PATCH v4 1/7] lib: string: add functions to case-convert strings Markus Mayer <mmayer@broadcom.com> - 2016-07-23 01:40 +0200
[PATCH v4 3/7] ACPI / device_sysfs: make use of new strtolower() function Markus Mayer <mmayer@broadcom.com> - 2016-07-23 01:40 +0200
[PATCH v4 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower() Markus Mayer <mmayer@broadcom.com> - 2016-07-23 01:40 +0200
[PATCH v4 2/7] drm/nouveau/core: make use of new strlcpytolower() function Markus Mayer <mmayer@broadcom.com> - 2016-07-23 01:40 +0200
csiph-web