Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1448788

[PATCH 3/9] staging: slicoss: ensure mapping of io-memory is uncached

Show all headers | View raw

From: Lino Sanfilippo <lsanfil@marvell.com>

Writes to registers should be done uncached for various reasons. Ensure
this by replacing ioremap() with ioremap_nocache().

Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
---
 drivers/staging/slicoss/slicoss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index a9323a9..4dba080 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -3136,7 +3136,7 @@ static int slic_entry_probe(struct pci_dev *pcidev,
 	mmio_start = pci_resource_start(pcidev, 0);
 	mmio_len = pci_resource_len(pcidev, 0);
 
-	memmapped_ioaddr = ioremap(mmio_start, mmio_len);
+	memmapped_ioaddr = ioremap_nocache(mmio_start, mmio_len);
 	if (!memmapped_ioaddr) {
 		dev_err(&pcidev->dev, "cannot remap MMIO region %lx @ %lx\n",
 			mmio_len, mmio_start);
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Slicoss fixes and improvements Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-07-22 23:20 +0200
  [PATCH 4/9] staging: slicoss: start tx queue when interface is brought up Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-07-22 23:20 +0200
  [PATCH 2/9] staging: slicoss: notifiy network stack about change in link state Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-07-22 23:20 +0200
  [PATCH 3/9] staging: slicoss: ensure mapping of io-memory is uncached Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-07-22 23:20 +0200
  [PATCH 7/9] staging: slicoss: dont use a structure but offsets for register accesses Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-07-22 23:20 +0200
  [PATCH 8/9] staging: slicoss: improve implementation concerning the shared memory Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-07-22 23:20 +0200
  [PATCH 5/9] staging: slicoss: introduce register accessors that use register offsets Lino Sanfilippo <LinoSanfilippo@gmx.de> - 2016-07-22 23:20 +0200

csiph-web