[PATCH] zsmalloc: Delete an unnecessary check before the function call "iput"

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH] zsmalloc: Delete an unnecessary check before the function call "iput"
Date	2016-07-22 20:10 +0200
Message-ID	<rXN3A-Qn-23@gated-at.bofh.it> (permalink)
References	(12 earlier) <mSsDN-4wa-59@gated-at.bofh.it> <mSsDN-4wa-61@gated-at.bofh.it> <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 22 Jul 2016 19:54:20 +0200

The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 mm/zsmalloc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 5e5237c..7b5fd2b 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -2181,8 +2181,7 @@ static int zs_register_migration(struct zs_pool *pool)
 static void zs_unregister_migration(struct zs_pool *pool)
 {
 	flush_work(&pool->free_work);
-	if (pool->inode)
-		iput(pool->inode);
+	iput(pool->inode);
 }
 
 /*
-- 
2.9.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] zsmalloc: Delete an unnecessary check before the function  call "iput" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-22 20:10 +0200
  Re: [PATCH] zsmalloc: Delete an unnecessary check before the  function call "iput" Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-07-25 03:00 +0200
  Re: [PATCH] zsmalloc: Delete an unnecessary check before the  function call "iput" Minchan Kim <minchan@kernel.org> - 2016-07-25 11:10 +0200

csiph-web