Re: [PATCH] Revert "pinctrl: amd: make it explicitly non-modular"

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Revert "pinctrl: amd: make it explicitly non-modular"
Date	2016-07-22 17:30 +0200
Message-ID	<rXKyJ-7ye-9@gated-at.bofh.it> (permalink)
References	<rWreN-54V-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jul 19, 2016 at 2:30 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:

> This reverts commit b8c2b10a9bc0272a20e096852f8fbbf361749dda.
>
> This patch was in my queue at the same time that a conversion of
> the same driver from bool --> tristate was pending and merged.
>
> That is commit 337ea0fb1535 ("pinctrl: Turn AMD support to tristate")
>
> Normally the conflict would show up in the build coverage I do,
> however in this case an avoidable instance of linux/module.h in
> linux/gpio/driver.h (!) causes the build failure to be masked and
> instead the tristate gets built-in even for selected "=m".
>
> In working on removing module.h from driver.h this issue was then
> revealed (along with other implicit module.h assumptions in gpio,
> and mfd -- which will be fixed separately.)
>
> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Patch applied with Jean's ACK.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Revert "pinctrl: amd: make it explicitly non-modular" Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-19 02:40 +0200
  Re: [PATCH] Revert "pinctrl: amd: make it explicitly non-modular" Jean Delvare <jdelvare@suse.de> - 2016-07-19 10:50 +0200
    Re: [PATCH] Revert "pinctrl: amd: make it explicitly non-modular" Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-07-19 15:50 +0200
      Re: [PATCH] Revert "pinctrl: amd: make it explicitly non-modular" Jean Delvare <jdelvare@suse.de> - 2016-07-20 23:20 +0200
  Re: [PATCH] Revert "pinctrl: amd: make it explicitly non-modular" Linus Walleij <linus.walleij@linaro.org> - 2016-07-22 17:30 +0200

csiph-web