Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1448634
| From | Sean Paul <seanpaul@chromium.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drm/bridge: ps8622: Delete an unnecessary check before backlight_device_unregister() |
| Date | 2016-07-22 17:30 +0200 |
| Message-ID | <rXKyJ-7ye-5@gated-at.bofh.it> (permalink) |
| References | (14 earlier) <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <pG3ux-5SM-5@gated-at.bofh.it> <rXIdA-5YC-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jul 22, 2016 at 8:54 AM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 22 Jul 2016 14:45:51 +0200
>
> The backlight_device_unregister() function tests whether its argument
> is NULL and then returns immediately.
> Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Applied to drm-misc
> ---
> drivers/gpu/drm/bridge/parade-ps8622.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c
> index 5cd8dd7..583b8ce 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8622.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8622.c
> @@ -636,9 +636,7 @@ static int ps8622_remove(struct i2c_client *client)
> {
> struct ps8622_bridge *ps8622 = i2c_get_clientdata(client);
>
> - if (ps8622->bl)
> - backlight_device_unregister(ps8622->bl);
> -
> + backlight_device_unregister(ps8622->bl);
> drm_bridge_remove(&ps8622->bridge);
>
> return 0;
> --
> 2.9.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] drm/bridge: ps8622: Delete an unnecessary check before backlight_device_unregister() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-22 15:00 +0200 Re: [PATCH] drm/bridge: ps8622: Delete an unnecessary check before backlight_device_unregister() Sean Paul <seanpaul@chromium.org> - 2016-07-22 17:30 +0200
csiph-web