Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1448616

Re: [RCF 1/3] hwmon: Add ads1118 driver

From Joshua Clayton <stillcompiling@gmail.com>
Newsgroups linux.kernel
Subject Re: [RCF 1/3] hwmon: Add ads1118 driver
Date 2016-07-22 16:40 +0200
Message-ID <rXJMl-72c-19@gated-at.bofh.it> (permalink)
References <rVluN-5cw-5@gated-at.bofh.it> <rVluN-5cw-3@gated-at.bofh.it> <rVmTU-5Vb-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Greetings Guenter,

Thank you for reviewing my submission.

On 07/15/2016 06:40 PM, Guenter Roeck wrote:
> On 07/15/2016 05:18 PM, Joshua Clayton wrote:
>> Add new driver for Texas Instruments ADS1118 and and ADS1018.
>> This driver works with ADS1018, because of code borrowed
>> from asd1015, which is similar, but I can only test ADS1118
>>
>
> Browsing through the datasheet, I think this should probably be implemented
> as iio driver (and iio already has a driver for ads1015).
>
> Jonathan, what do you think ?
>
> Thanks,
> Guenter
>
No response from Jonathan as yet, but I am willing to rework the driver when I
have some time. It might be weeks before I can start, though.

I am not very familiar with the iio subsystem, (actually had never heard of it before
receiving your response). Learning it might be beneficial, as it looks like a good fit
for an in house driver, which I'd like to eventually upstream.

If an hwmon driver is adequate, I have new patches that address kbuild and endianness
issues in the first version.


~Joshua Clayton

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RCF 1/3] hwmon: Add ads1118 driver Joshua Clayton <stillcompiling@gmail.com> - 2016-07-16 02:20 +0200
  Re: [RCF 1/3] hwmon: Add ads1118 driver Guenter Roeck <linux@roeck-us.net> - 2016-07-16 03:50 +0200
    Re: [RCF 1/3] hwmon: Add ads1118 driver Joshua Clayton <stillcompiling@gmail.com> - 2016-07-22 16:40 +0200
      ADS1118: hwmon or iio ? [was: Re: [RCF 1/3] hwmon: Add ads1118  driver] Guenter Roeck <linux@roeck-us.net> - 2016-07-23 03:30 +0200
        Re: ADS1118: hwmon or iio ? [was: Re: [RCF 1/3] hwmon: Add ads1118  driver] Jonathan Cameron <jic23@kernel.org> - 2016-07-23 13:00 +0200
      Re: [RCF 1/3] hwmon: Add ads1118 driver Jonathan Cameron <jic23@kernel.org> - 2016-07-23 13:00 +0200
  Re: [RCF 1/3] hwmon: Add ads1118 driver kbuild test robot <lkp@intel.com> - 2016-07-16 19:30 +0200

csiph-web