Re: [PATCH] [media] tw686x-kh: Delete an unnecessary check before the function call "video_unregister_device"

From	khalasa@piap.pl (Krzysztof Hałasa)
Newsgroups	linux.kernel
Subject	Re: [PATCH] [media] tw686x-kh: Delete an unnecessary check before the function call "video_unregister_device"
Date	2016-07-22 12:30 +0200
Message-ID	<rXFSq-4xq-29@gated-at.bofh.it> (permalink)
References	(13 earlier) <mSsDN-4wa-61@gated-at.bofh.it> <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <rW0HE-5da-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

SF Markus Elfring <elfring@users.sourceforge.net> writes:

> The video_unregister_device() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/staging/media/tw686x-kh/tw686x-kh-video.c | 3 +--

Thanks.
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [media] tw686x-kh: Delete an unnecessary check before the  function call "video_unregister_device" SF Markus Elfring <elfring@users.sourceforge.net> - 2016-07-17 22:20 +0200
  Re: [PATCH] [media] tw686x-kh: Delete an unnecessary check before the function call "video_unregister_device" khalasa@piap.pl (Krzysztof Hałasa) - 2016-07-22 12:30 +0200

csiph-web