Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1448524

Re: Aw: BUG: Wrong dma queue handling in ixp4 driver

From khalasa@piap.pl (Krzysztof Hałasa)
Newsgroups linux.kernel
Subject Re: Aw: BUG: Wrong dma queue handling in ixp4 driver
Date 2016-07-22 12:30 +0200
Message-ID <rXFSq-4xq-17@gated-at.bofh.it> (permalink)
References <rWB4t-3hE-11@gated-at.bofh.it> <rWBxw-3r9-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Lino,

"Lino Sanfilippo" <LinoSanfilippo@gmx.de> writes:

>> maybe I miss something, but the ixp4 ethernet driver seems to handle dma pools 
>> in a wrong way: In init_queues() it creates a dma pool for descriptors and then
>>  only allocates a single descriptor from this pool. The author seems to assume the whole
>> table has been allocated already, since after that the complete pool size is zeroed:
>> 
>
> Sorry, I indeed missed something. The allocation is correct. A pool is not required, though,
> since only one chunk is allocated.

Not really: there is one pool for all ports, but each port uses
a separate desc_tab (allocated from that pool).
-- 
Krzysztof Halasa

Industrial Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

BUG: Wrong dma queue handling in ixp4 driver "Lino Sanfilippo" <LinoSanfilippo@gmx.de> - 2016-07-19 13:10 +0200
  Aw: BUG: Wrong dma queue handling in ixp4 driver "Lino Sanfilippo" <LinoSanfilippo@gmx.de> - 2016-07-19 13:40 +0200
    Re: Aw: BUG: Wrong dma queue handling in ixp4 driver khalasa@piap.pl (Krzysztof Hałasa) - 2016-07-22 12:30 +0200
      Aw: Re:  BUG: Wrong dma queue handling in ixp4 driver "Lino Sanfilippo" <LinoSanfilippo@gmx.de> - 2016-07-22 13:20 +0200

csiph-web