Re: [PATCH] update sc->nr_reclaimed after each shrink_slab

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] update sc->nr_reclaimed after each shrink_slab
Date	2016-07-22 10:20 +0200
Message-ID	<rXDQC-3e4-13@gated-at.bofh.it> (permalink)
References	<rXzDj-hE-5@gated-at.bofh.it> <rXDnA-2NF-11@gated-at.bofh.it> <rXDQC-3e4-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri 22-07-16 11:12:59, Vladimir Davydov wrote:
> On Fri, Jul 22, 2016 at 09:49:13AM +0200, Michal Hocko wrote:
> > On Fri 22-07-16 11:43:30, Zhou Chengming wrote:
> > > In !global_reclaim(sc) case, we should update sc->nr_reclaimed after each
> > > shrink_slab in the loop. Because we need the correct sc->nr_reclaimed
> > > value to see if we can break out.
> > 
> > Does this actually change anything? Maybe I am missing something but
> > try_to_free_mem_cgroup_pages which is the main entry for the memcg
> > reclaim doesn't set reclaim_state. I don't remember why... Vladimir?
> 
> We don't set reclaim_state on memcg reclaim, because there might be a
> lot of unrelated slab objects freed from the interrupt context (e.g.
> RCU freed) while we're doing memcg reclaim. Obviously, we don't want
> them to contribute to nr_reclaimed.
> 
> Link to the thread with the problem discussion:
> 
>   http://marc.info/?l=linux-kernel&m=142132698209680&w=2

Ohh, now I rememeber again. Thanks for the refresh ;)

So the patch doesn't make any difference in the end.
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] update sc->nr_reclaimed after each shrink_slab Zhou Chengming <zhouchengming1@huawei.com> - 2016-07-22 05:50 +0200
  Re: [PATCH] update sc->nr_reclaimed after each shrink_slab Michal Hocko <mhocko@kernel.org> - 2016-07-22 09:50 +0200
    Re: [PATCH] update sc->nr_reclaimed after each shrink_slab Michal Hocko <mhocko@kernel.org> - 2016-07-22 10:20 +0200

csiph-web