Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1448431
| From | Jacek Anaszewski <j.anaszewski@samsung.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v6 2/2] Bindings documentation for ISSI is31fl319x driver |
| Date | 2016-07-22 09:20 +0200 |
| Message-ID | <rXCUy-2Cb-1@gated-at.bofh.it> (permalink) |
| References | <rWBHb-3uo-11@gated-at.bofh.it> <rWBHb-3uo-9@gated-at.bofh.it> <rWOuK-38Z-17@gated-at.bofh.it> <rXChQ-28l-9@gated-at.bofh.it> <rXCrv-2c7-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 07/22/2016 08:42 AM, H. Nikolaus Schaller wrote: > Hi, > >> Am 22.07.2016 um 08:36 schrieb Jacek Anaszewski <j.anaszewski@samsung.com>: >> >> On 07/20/2016 03:24 AM, Rob Herring wrote: >>> On Tue, Jul 19, 2016 at 01:47:31PM +0200, H. Nikolaus Schaller wrote: >>>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >>>> --- >>>> .../devicetree/bindings/leds/is31fl319x.txt | 59 ++++++++++++++++++++++ >>>> 1 file changed, 59 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/leds/is31fl319x.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/leds/is31fl319x.txt b/Documentation/devicetree/bindings/leds/is31fl319x.txt >>>> new file mode 100644 >>>> index 0000000..03287c0 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/leds/is31fl319x.txt >>>> @@ -0,0 +1,59 @@ >>>> +LEDs connected to is31fl319x LED controller chip >>>> + >>>> +Required properties: >>>> +- compatible : Should be any of >>>> + "issi,is31fl3190" >>>> + "issi,is31fl3191" >>>> + "issi,is31fl3193" >>>> + "issi,is31fl3196" >>>> + "issi,is31fl3199" >>>> + "si-en,sn3199". >>>> +- #address-cells: Must be 1. >>>> +- #size-cells: Must be 0. >>>> +- reg: 0x64, 0x65, 0x66, 0x67. >>> >>> This is an OR or AND? OR it seems. With that, >> >> Nikolaus, could you please make it explicit? > > Yes, Rob's intuition is right. An AND does > obviously not make sense for a reg property. > > It is an OR. > > So if you perfer, please substitute > > - reg: 0x64, 0x65, 0x66, or 0x67. Updated the for-4.9 branch accordingly. I also added "led-" prefix to the file name to match it with the vast majority of the remaining ones. -- Best regards, Jacek Anaszewski
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v6 0/2] driver: leds: is31fl319x dimmable LED driver "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-07-19 13:50 +0200
[PATCH v6 2/2] Bindings documentation for ISSI is31fl319x driver "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-07-19 13:50 +0200
Re: [PATCH v6 2/2] Bindings documentation for ISSI is31fl319x driver Rob Herring <robh@kernel.org> - 2016-07-20 03:30 +0200
Re: [PATCH v6 2/2] Bindings documentation for ISSI is31fl319x driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-07-22 08:40 +0200
Re: [PATCH v6 2/2] Bindings documentation for ISSI is31fl319x driver "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-07-22 08:50 +0200
Re: [PATCH v6 2/2] Bindings documentation for ISSI is31fl319x driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-07-22 09:20 +0200
[PATCH v6 1/2] led: is31fl319x: 1/3/6/9-channel light effect led driver "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-07-19 13:50 +0200
Re: [PATCH v6 1/2] led: is31fl319x: 1/3/6/9-channel light effect led driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-07-19 14:30 +0200
Re: [PATCH v6 1/2] led: is31fl319x: 1/3/6/9-channel light effect led driver "H. Nikolaus Schaller" <hns@goldelico.com> - 2016-07-19 14:40 +0200
csiph-web