Re: [PATCH] ARM: shmobile: don't call platform_can_secondary_boot on UP

From	Simon Horman <horms@verge.net.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ARM: shmobile: don't call platform_can_secondary_boot on UP
Date	2016-07-21 01:20 +0200
Message-ID	<rX8Wu-7Sc-15@gated-at.bofh.it> (permalink)
References	<rPJgt-15H-1@gated-at.bofh.it> <rPJTc-1y9-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 30, 2016 at 03:09:46PM +0200, Geert Uytterhoeven wrote:
> Hi Arnd,
> 
> On Thu, Jun 30, 2016 at 2:25 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > For rcar-gen2, we build the SMP files even for UP configurations,
> > and that just broke:
> >
> > arch/arm/mach-shmobile/built-in.o: In function `shmobile_smp_init_fallback_ops':
> > pm-rcar-gen2.c:(.init.text+0x40c): undefined reference to `platform_can_secondary_boot'
> >
> > This adds an compile-time check before the call to platform_can_secondary_boot,
> > turning the function into an empty stub for UP configurations.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: c21af444eace ("ARM: shmobile: smp: Add function to prioritize DT SMP")
> 
> Crap, I think I took the shortcut of only compile-testing
> arch/arm/mach-shmobile,
> not link-testing the whole kernel, with CONFIG_SMP=n...
> 
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Sorry for missing this until now.
I have queued it up as a fix for v4.7.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] ARM: shmobile: don't call platform_can_secondary_boot on  UP Simon Horman <horms@verge.net.au> - 2016-07-21 01:20 +0200

csiph-web